Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR - Prepare App Instances & fix bigtable json #15292

Merged
merged 8 commits into from
Feb 23, 2024

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Feb 21, 2024

Describe your changes:

The main change here is to:

  • do not initialize the app multiple times (after every configure, trigger, etc.)
  • allow us to pick up initialized instances of applications. This is needed for Collate MetaPilot resource

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@pmbrull pmbrull requested a review from a team as a code owner February 21, 2024 11:50
@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 21, 2024
@pmbrull pmbrull changed the title MINOR - Prepare App Exception & fix bigtable json MINOR - Prepare App Instances & fix bigtable json Feb 22, 2024
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@pmbrull pmbrull merged commit cc878bf into open-metadata:main Feb 23, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants