aligned pre-commit with Makefile. added check json #15295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
pmbrull
previously approved these changes
Feb 22, 2024
pmbrull
reviewed
Feb 22, 2024
| # access to secrets | ||
| on: | ||
| pull_request_target: | ||
| types: [labeled, opened, synchronize, reopened] |
There was a problem hiding this comment.
should we limit this to certain paths where we have the schemas / yaml examples?
pmbrull
approved these changes
Apr 18, 2024
ulixius9
pushed a commit
that referenced
this pull request
Apr 22, 2024
* aligned pre-commit with Makefile. added check json * add check for json/yaml files * add path checks for json/yaml validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Following commit of bad json file: #15292
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>