Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Spaces and Tabs of YAML in workflow CI #15309

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

akash-jain-10
Copy link
Collaborator

Spaces and Tabs of YAML in workflow CI

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added devops safe to test Add this label to run secure Github workflows on PRs labels Feb 22, 2024
@akash-jain-10 akash-jain-10 self-assigned this Feb 22, 2024
@akash-jain-10 akash-jain-10 enabled auto-merge (squash) February 22, 2024 09:35
Copy link
Contributor

@dhruvinmaniar123 dhruvinmaniar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akash-jain-10 akash-jain-10 merged commit 925fec5 into main Feb 22, 2024
11 checks passed
@akash-jain-10 akash-jain-10 deleted the fix/cypress-pr-ci branch February 22, 2024 09:40
chirag-madlani added a commit that referenced this pull request Feb 26, 2024
* chore(ui): improve ui / ux around patch api calls

* domain loading changes

* add loading state to entityReName modal

* added loading state for following

* setLoading false in entityName modal

* delete style fix

* updated vote loading and delete loading for queries

* fixed loading issue in profilerSettingsModal

* fixed no data placeholder issue while loading in thread drawer

* fix glossary term related changes

* fix glossary term related changes

* fix: Spaces and Tabs of YAML (#15309)

* fix: Simplify the logic for get cypress filter step

* ui/ux fix

* added tooltip on icons

* localizaion keys

* minor changes

* fixed profiler picture loading issue

* Fix UI-UX (#15313)

* incident manager edit displayName loading

* no data placeholder for no search data

* code refactor

* address comments

* fetch latest data in tagsPage

* fix edit description icon alignment

* edit icon fix

* fixed failing unit test

* revert version tests

* addressing comment

---------

Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
Co-authored-by: Akash Jain <15995028+akash-jain-10@users.noreply.github.com>
Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Co-authored-by: Harsh Vador <58542468+harsh-vador@users.noreply.github.com>
ShaileshParmar11 added a commit that referenced this pull request Feb 26, 2024
* chore(ui): improve ui / ux around patch api calls

* domain loading changes

* add loading state to entityReName modal

* added loading state for following

* setLoading false in entityName modal

* delete style fix

* updated vote loading and delete loading for queries

* fixed loading issue in profilerSettingsModal

* fixed no data placeholder issue while loading in thread drawer

* fix glossary term related changes

* fix glossary term related changes

* fix: Spaces and Tabs of YAML (#15309)

* fix: Simplify the logic for get cypress filter step

* ui/ux fix

* added tooltip on icons

* localizaion keys

* minor changes

* fixed profiler picture loading issue

* Fix UI-UX (#15313)

* incident manager edit displayName loading

* no data placeholder for no search data

* code refactor

* address comments

* fetch latest data in tagsPage

* fix edit description icon alignment

* edit icon fix

* fixed failing unit test

* revert version tests

* addressing comment

---------

Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
Co-authored-by: Akash Jain <15995028+akash-jain-10@users.noreply.github.com>
Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Co-authored-by: Harsh Vador <58542468+harsh-vador@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants