Fix UI-UX #15313
Merged
Fix UI-UX #15313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-vador
requested review from
harshach,
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
github-actions
bot
added
UI
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
chirag-madlani
added
the
safe to test
chirag-madlani
approved these changes
Feb 23, 2024
ShaileshParmar11
merged commit c6d5f68
into
open-metadata:fix-ui-ux
7 of 15 checks passed
9 tasks
chirag-madlani
added a commit
that referenced
this pull request
Feb 26, 2024
* chore(ui): improve ui / ux around patch api calls * domain loading changes * add loading state to entityReName modal * added loading state for following * setLoading false in entityName modal * delete style fix * updated vote loading and delete loading for queries * fixed loading issue in profilerSettingsModal * fixed no data placeholder issue while loading in thread drawer * fix glossary term related changes * fix glossary term related changes * fix: Spaces and Tabs of YAML (#15309) * fix: Simplify the logic for get cypress filter step * ui/ux fix * added tooltip on icons * localizaion keys * minor changes * fixed profiler picture loading issue * Fix UI-UX (#15313) * incident manager edit displayName loading * no data placeholder for no search data * code refactor * address comments * fetch latest data in tagsPage * fix edit description icon alignment * edit icon fix * fixed failing unit test * revert version tests * addressing comment --------- Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com> Co-authored-by: Akash Jain <15995028+akash-jain-10@users.noreply.github.com> Co-authored-by: Ashish Gupta <ashish@getcollate.io> Co-authored-by: Harsh Vador <58542468+harsh-vador@users.noreply.github.com>
ShaileshParmar11
added a commit
that referenced
this pull request
Feb 26, 2024
* chore(ui): improve ui / ux around patch api calls * domain loading changes * add loading state to entityReName modal * added loading state for following * setLoading false in entityName modal * delete style fix * updated vote loading and delete loading for queries * fixed loading issue in profilerSettingsModal * fixed no data placeholder issue while loading in thread drawer * fix glossary term related changes * fix glossary term related changes * fix: Spaces and Tabs of YAML (#15309) * fix: Simplify the logic for get cypress filter step * ui/ux fix * added tooltip on icons * localizaion keys * minor changes * fixed profiler picture loading issue * Fix UI-UX (#15313) * incident manager edit displayName loading * no data placeholder for no search data * code refactor * address comments * fetch latest data in tagsPage * fix edit description icon alignment * edit icon fix * fixed failing unit test * revert version tests * addressing comment --------- Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com> Co-authored-by: Akash Jain <15995028+akash-jain-10@users.noreply.github.com> Co-authored-by: Ashish Gupta <ashish@getcollate.io> Co-authored-by: Harsh Vador <58542468+harsh-vador@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
I worked on fixing ui ux issues in data quality page:
Screen.Recording.2024-02-22.at.4.38.34.PM.mov
Screen.Recording.2024-02-22.at.4.36.31.PM.mov
Screen.Recording.2024-02-23.at.1.55.25.PM.1.1.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>