Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Activity feed revamp #15716

Merged
merged 54 commits into from
May 6, 2024
Merged

Feat: Activity feed revamp #15716

merged 54 commits into from
May 6, 2024

Conversation

aniketkatkar97
Copy link
Member

@aniketkatkar97 aniketkatkar97 commented Mar 27, 2024

Describe your changes:

Fixes #13871

  • I worked on revamping the activity feed!
image image image image image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Documentation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Mar 27, 2024
@harshach
Copy link
Collaborator

harshach commented May 3, 2024

@Rupchavan classification icon doesn't look right

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to ActivityFeedCard?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have the old file for ActivityFeedCard and it is being used, will remove once it dependency is removed!

@@ -480,6 +487,7 @@ a[href].link-text-grey,
// breadcrumb

.breadcrumb-item {
max-width: 100%;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this to be applied to all the breadcrumb?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, so the case was a breadcrumb item was overflowing due the continuous string in it present. so this max-width will only used the width of the container and the split to the next line.

Copy link

sonarqubecloud bot commented May 6, 2024

Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 23a526d into main May 6, 2024
16 of 22 checks passed
@chirag-madlani chirag-madlani deleted the feat-activity-feed-revamp branch May 6, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend e2e:Governance e2e:Settings safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing feed response based on the their type in UI
5 participants