-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Activity feed revamp #15716
Feat: Activity feed revamp #15716
Conversation
@Rupchavan classification icon doesn't look right |
...in/resources/ui/src/components/ActivityFeed/ActivityFeedCard/FeedCardBody/FeedCardBodyV1.tsx
Outdated
Show resolved
Hide resolved
...esources/ui/src/components/ActivityFeed/ActivityFeedCard/FeedCardBody/feed-card-body-v1.less
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this to ActivityFeedCard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still have the old file for ActivityFeedCard
and it is being used, will remove once it dependency is removed!
@@ -480,6 +487,7 @@ a[href].link-text-grey, | |||
// breadcrumb | |||
|
|||
.breadcrumb-item { | |||
max-width: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this to be applied to all the breadcrumb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, so the case was a breadcrumb item was overflowing due the continuous string in it present. so this max-width will only used the width of the container and the split to the next line.
Quality Gate passed for 'open-metadata-ui'Issues Measures |
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
Describe your changes:
Fixes #13871
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>