Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Activity feed revamp #15716

Merged
merged 54 commits into from
May 6, 2024
Merged
Show file tree
Hide file tree
Changes from 53 commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
a86ad60
add new activity feed card component according to the new designs
aniketkatkar97 Mar 27, 2024
50c929c
add new localization values
aniketkatkar97 Mar 27, 2024
80dc03b
replace the old ActivityFeedCardV1 component with the new ActivityFee…
aniketkatkar97 Mar 27, 2024
faed124
Merge branch 'main' into feat-activity-feed-revamp
aniketkatkar97 Mar 27, 2024
5e0d46e
Merge branch 'main' into feat-activity-feed-revamp
aniketkatkar97 Apr 2, 2024
d3c387b
Merge branch 'main' into feat-activity-feed-revamp
aniketkatkar97 Apr 2, 2024
9c1f5bf
Merge branch 'main' into feat-activity-feed-revamp
aniketkatkar97 Apr 2, 2024
73f486e
Merge branch 'main' into feat-activity-feed-revamp
aniketkatkar97 Apr 3, 2024
bc7a5c2
add the delete and edit options for the feeds
aniketkatkar97 Apr 3, 2024
c4c5ea9
Merge branch 'main' into feat-activity-feed-revamp
aniketkatkar97 Apr 4, 2024
b6f4704
Merge branch 'main' into feat-activity-feed-revamp
aniketkatkar97 Apr 4, 2024
ffc2ea1
move new activity feed card component to a common folder
aniketkatkar97 Apr 4, 2024
9d40319
Merge remote-tracking branch 'origin/main' into feat-activity-feed-re…
aniketkatkar97 Apr 22, 2024
7f3c435
Refactor activity feed header to implement new backend changes
aniketkatkar97 Apr 22, 2024
a73a75e
Merge branch 'main' into feat-activity-feed-revamp
aniketkatkar97 Apr 22, 2024
0c7a5fa
Refactor activity feed header to implement new backend changes
aniketkatkar97 Apr 22, 2024
be41678
Merge branch 'main' into feat-activity-feed-revamp
aniketkatkar97 Apr 22, 2024
a422a7d
Add DescriptionFeed component to show feed info for description changes
aniketkatkar97 Apr 23, 2024
a66a8d9
Improve getFeedChangeOperationLabel util function
aniketkatkar97 Apr 23, 2024
925fdbc
Fix activity feed card styling to remove text primary color on hover
aniketkatkar97 Apr 23, 2024
de902a1
Merge branch 'main' into feat-activity-feed-revamp
aniketkatkar97 Apr 23, 2024
99109b6
Merge branch 'main' into feat-activity-feed-revamp
aniketkatkar97 Apr 24, 2024
29761d0
Merge branch 'main' into feat-activity-feed-revamp
aniketkatkar97 Apr 24, 2024
fcf826e
Refactor code for ActivityFeedCardV2 component and add new test case …
aniketkatkar97 Apr 24, 2024
eb9f1b9
Update localization files for test status pluralization
aniketkatkar97 Apr 24, 2024
0a97a01
Update cardStyle enum values in thread.json schema
aniketkatkar97 Apr 24, 2024
01f3ec9
Update feed header messages
aniketkatkar97 Apr 24, 2024
ebdd6f6
Update localization files for feed headers
aniketkatkar97 Apr 24, 2024
152a2df
Update feed body to display asset details for entityCreated, entityDe…
aniketkatkar97 Apr 25, 2024
9a7a14a
Update localization files for soft-deleted-lowercase translation
aniketkatkar97 Apr 25, 2024
47d6958
Add tags feed component show feeds related to tags
aniketkatkar97 Apr 25, 2024
59e60cd
Update localization files for added and removed entity translations
aniketkatkar97 Apr 25, 2024
c809329
Refactor TagsFeed component to remove unnecessary code
aniketkatkar97 Apr 25, 2024
a52ef06
Merge branch 'main' of github.com:open-metadata/OpenMetadata into fea…
Ashish8689 Apr 30, 2024
dfcc87b
- Send Actual Field Name
mohityadav766 Apr 30, 2024
383226a
- Add json Type in one thread.json
mohityadav766 Apr 30, 2024
56e7151
added feed support for customProperty
Ashish8689 Apr 30, 2024
013ec9a
localization keys
Ashish8689 Apr 30, 2024
60465bf
Merge branch 'main' of github.com:open-metadata/OpenMetadata into fea…
Ashish8689 Apr 30, 2024
cff81dd
fix sonar issue
Ashish8689 Apr 30, 2024
4739221
Merge branch 'main' into feat-activity-feed-revamp
aniketkatkar97 May 1, 2024
848caa8
changes made as per comments
Ashish8689 May 2, 2024
e6938d1
localization keys
Ashish8689 May 2, 2024
c056da0
fix feed message not coming up
Ashish8689 May 2, 2024
833bbcb
testCaseFeed fix
Ashish8689 May 3, 2024
15b222d
localizaion keys added
Ashish8689 May 3, 2024
e0dee7b
Merge branch 'main' of github.com:open-metadata/OpenMetadata into fea…
Ashish8689 May 3, 2024
5c27c9e
removed action button on system generated feed
Ashish8689 May 3, 2024
36db664
fix redirect link for alerts feed
Ashish8689 May 3, 2024
b10f5c0
Merge branch 'main' of github.com:open-metadata/OpenMetadata into fea…
Ashish8689 May 5, 2024
97e8b05
fix the classification and glossary feed card icon
Ashish8689 May 5, 2024
f39ffd1
fix the classification icon and card ui overflow
Ashish8689 May 6, 2024
b42b5df
minor fix
Ashish8689 May 6, 2024
6c857ad
changes as per comments
Ashish8689 May 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package org.openmetadata.service.formatter.field;

import static org.openmetadata.service.Entity.FIELD_EXTENSION;

import org.openmetadata.schema.entity.feed.CustomPropertyFeedInfo;
import org.openmetadata.schema.entity.feed.FeedInfo;
import org.openmetadata.schema.entity.feed.Thread;
Expand Down Expand Up @@ -53,7 +51,7 @@ private void populateCustomPropertiesInfo(Thread.FieldOperation operation, Strin
.withHeaderMessage(
getHeaderForCustomPropertyUpdate(
thread.getUpdatedBy(), operation.value(), thread.getEntityUrlLink()))
.withFieldName(FIELD_EXTENSION)
.withFieldName(fieldChangeName)
.withEntitySpecificInfo(customPropertyFeedInfo);
populateThreadFeedInfo(
thread, threadMessage, Thread.CardStyle.CUSTOM_PROPERTIES, operation, feedInfo);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@
"type": "string"
},
"testCaseResolutionStatusId": {
"description": "The test case resolution status id for which the task is created.",
"$ref": "../../type/basic.json#/definitions/uuid"
"description": "The test case resolution status id for which the task is created.",
"$ref": "../../type/basic.json#/definitions/uuid"
}
},
"required": ["id", "assignees", "type"],
Expand Down Expand Up @@ -228,7 +228,20 @@
"cardStyle": {
"description": "Card style for the thread.",
"type": "string",
"enum": ["default", "logicalTestCaseAdded", "entityCreated", "entityDeleted", "entitySoftDeleted", "description", "tags", "owner", "testCaseResult", "customProperties", "assets", "domain"],
"enum": [
"default",
"logicalTestCaseAdded",
"entityCreated",
"entityDeleted",
"entitySoftDeleted",
"description",
"tags",
"owner",
"testCaseResult",
"customProperties",
"assets",
"domain"
],
"default": "default"
},
"fieldOperation": {
Expand All @@ -242,29 +255,35 @@
"type": "object",
"properties": {
"headerMessage": {
"description": "Header message for the feed.",
"type": "string"
"description": "Header message for the feed.",
"type": "string"
},
"fieldName": {
"description": "Field Name message for the feed.",
"type": "string"
"description": "Field Name message for the feed.",
"type": "string"
},
"entitySpecificInfo": {
"oneOf": [
{
"$ref": "./assets.json"
},
{
"$ref": "./customProperty.json"
},
{
"$ref": "./description.json"
},
{
"$ref": "./owner.json"
"$ref": "./domain.json"
},
{
"$ref": "./testCaseResult.json"
"$ref": "./entityInfo.json"
},
{
"$ref": "./tag.json"
},
{
"$ref": "./entityInfo.json"
"$ref": "./testCaseResult.json"
}
]
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 8 additions & 8 deletions openmetadata-ui/src/main/resources/ui/src/assets/svg/tag.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,19 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { AnnouncementDetails } from '../../../../generated/entity/feed/thread';
import {
AnnouncementDetails,
Thread,
} from '../../../../generated/entity/feed/thread';

export interface FeedCardBodyV1Props {
feed: Thread;
isEditPost: boolean;
className?: string;
showSchedule?: boolean;
announcement?: AnnouncementDetails;
message: string;
isPost?: boolean;
isOpenInDrawer?: boolean;
onUpdate?: (message: string) => void;
onEditCancel?: () => void;
Expand Down
Loading
Loading