Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): show glossary terms in hierarchy form #15823

Merged
merged 18 commits into from
Apr 26, 2024
Merged

(feat): show glossary terms in hierarchy form #15823

merged 18 commits into from
Apr 26, 2024

Conversation

harsh-vador
Copy link
Contributor

@harsh-vador harsh-vador commented Apr 5, 2024 •
edited by chirag-madlani
Loading

Describe your changes:

Fixes: #13917, #10724

Screen.Recording.2024-04-20.at.3.21.25.PM.mov

I worked on showing the glossary terms in hierarchical way in entity right panel.

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added e2e:Governance UI UI specific issues and removed e2e:Governance labels Apr 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@chirag-madlani chirag-madlani force-pushed the glossary-terms-hierarchy branch from bcd76ff to 1d33939 Compare April 12, 2024 10:23
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@chirag-madlani chirag-madlani added the safe to test Add this label to run secure Github workflows on PRs label Apr 18, 2024
@chirag-madlani chirag-madlani marked this pull request as ready for review April 21, 2024 07:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 21, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.72% (33964/52476) 41.84% (13310/31815) 43.35% (4175/9630)

@cypress Cypress
Copy link

cypress bot commented Apr 21, 2024 •
edited
Loading

1 failed test on run #33991 ↗︎

1 520 0 0 Flakiness 0

Details:

fix count issue for tags page
Project: openmetadata Commit: 2017bdaa48
Status: Failed Duration: 50:41 💡
Started: Apr 26, 2024 6:23 AM Ended: Apr 26, 2024 7:13 AM
Failed  cypress/e2e/Service/ServiceIngestion.spec.ts • 1 failed test • cypress-ci-mysql-pr-8843847748-1

View Output Video

Test Artifacts
Airflow Ingestion > Create & Ingest Airflow service Screenshots Video

Review all test suite changes for PR #15823 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

ShaileshParmar11
ShaileshParmar11 reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few comments

.../components/Settings/Services/Ingestion/IngestionRecentRun/IngestionRecentRuns.component.tsx Show resolved Hide resolved
...ui/src/main/resources/ui/src/components/Tag/TagsSelectForm/TagsSelectForm.component.test.tsx Outdated Show resolved Hide resolved
...adata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx Outdated Show resolved Hide resolved
...adata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx Show resolved Hide resolved
...adata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx Show resolved Hide resolved
...adata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx Outdated Show resolved Hide resolved
...adata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
11.1% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 5125ebc into open-metadata:main Apr 26, 2024
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees
No one assigned
Labels
e2e:Governance e2e:Integration e2e:Settings safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag suggested window covers it's action button
4 participants
@harsh-vador @chirag-madlani @Sachin-chaurasiya @ShaileshParmar11