GEN-1983 : Feat - Support Tag Asset Page #18505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonika-shah
added
backend
safe to test
sonika-shah
changed the title
harshach
reviewed
Nov 5, 2024
| @@ -109,6 +122,82 @@ public void setFullyQualifiedName(Tag tag) { | |||
| } | |||
| } | |||
|
|
|||
| public BulkOperationResult bulkAddAndValidateTagToAssets( | |||
There was a problem hiding this comment.
@harshach , this is sync operation , similar to the current implementation that we have for adding assets to glossaryTerm on Assets tab
* create branch * update add asset API * add websocket on tags page --------- Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com> Co-authored-by: karanh37 <karanh37@gmail.com>
|
|
mohityadav766
approved these changes
Nov 18, 2024
chirag-madlani
approved these changes
Nov 18, 2024
karanh37
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Feat : Support bulk adding tag to Assets * remove warnings * add apis for assets remove * Fix: Add tag page (#18461) * add tag page which all Assets * update as per feedbacks * update as per feedbacks * add divider in header badge * remove styling * update permission and refactoring code * updated as per comments * fix sonar cloud issues * add delete asset functionality * refactor entityTypeString * made the top bar fixed to top * add tests for tag page * fix check failures issue * fix tag page check failure * fix flaky test issue * add tag page tests * update the add asset test * update playwright tests * add right panel in tag page * updated as per feedbacks * remove usage test * updated as per feedbacks --------- * Backend: make bulkAssets api async * Backend: limit bulkAssets api async to Tag Assets page * Update Tag page Assets API (#18622) * create branch * update add asset API * add websocket on tags page --------- Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com> Co-authored-by: karanh37 <karanh37@gmail.com> * add failed case for socket operation --------- Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com> Co-authored-by: Sweta Agarwalla <105535990+sweta1308@users.noreply.github.com> Co-authored-by: karanh37 <karanh37@gmail.com> (cherry picked from commit 853bbc2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Feat : Support bulk adding tag to Assets - async operation
Fix : #15541
Screen.Recording.2024-11-15.at.4.24.24.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>