Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tag page Assets API #18622

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

sweta1308
Copy link
Contributor

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

1 similar comment
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@karanh37 karanh37 merged commit 52c4b65 into open-metadata:feat-bulkAddTagtoAssets Nov 15, 2024
8 of 15 checks passed
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

karanh37 added a commit that referenced this pull request Nov 18, 2024
* Feat :  Support bulk adding tag to Assets

* remove warnings

* add apis for assets remove

* Fix: Add tag page (#18461)

* add tag page which all Assets

* update as per feedbacks

* update as per feedbacks

* add divider in header badge

* remove styling

* update permission and refactoring code

* updated as per comments

* fix sonar cloud issues

* add delete asset functionality

* refactor entityTypeString

* made the top bar fixed to top

* add tests for tag page

* fix check failures issue

* fix tag page check failure

* fix flaky test issue

* add tag page tests

* update the add asset test

* update playwright tests

* add right panel in tag page

* updated as per feedbacks

* remove usage test

* updated as per feedbacks

---------

* Backend: make bulkAssets api async

* Backend: limit bulkAssets api async to Tag Assets page

* Update Tag page Assets API (#18622)

* create branch

* update add asset API

* add websocket on tags page

---------

Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>
Co-authored-by: karanh37 <karanh37@gmail.com>

* add failed case for socket operation

---------

Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>
Co-authored-by: Sweta Agarwalla <105535990+sweta1308@users.noreply.github.com>
Co-authored-by: karanh37 <karanh37@gmail.com>
karanh37 pushed a commit that referenced this pull request Nov 18, 2024
* Feat :  Support bulk adding tag to Assets

* remove warnings

* add apis for assets remove

* Fix: Add tag page (#18461)

* add tag page which all Assets

* update as per feedbacks

* update as per feedbacks

* add divider in header badge

* remove styling

* update permission and refactoring code

* updated as per comments

* fix sonar cloud issues

* add delete asset functionality

* refactor entityTypeString

* made the top bar fixed to top

* add tests for tag page

* fix check failures issue

* fix tag page check failure

* fix flaky test issue

* add tag page tests

* update the add asset test

* update playwright tests

* add right panel in tag page

* updated as per feedbacks

* remove usage test

* updated as per feedbacks

---------

* Backend: make bulkAssets api async

* Backend: limit bulkAssets api async to Tag Assets page

* Update Tag page Assets API (#18622)

* create branch

* update add asset API

* add websocket on tags page

---------

Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>
Co-authored-by: karanh37 <karanh37@gmail.com>

* add failed case for socket operation

---------

Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>
Co-authored-by: Sweta Agarwalla <105535990+sweta1308@users.noreply.github.com>
Co-authored-by: karanh37 <karanh37@gmail.com>
(cherry picked from commit 853bbc2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants