Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes GEN-2199: Allow Fivetran filtering of pipelines using name instead of id #18929

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Fixes GEN-2199: Allow Fivetran filtering of pipelines using name instead of id #18929

merged 2 commits into from
Dec 5, 2024

Conversation

ayush-shah
Copy link
Member

Describe your changes:

Fixes GEN-2199

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ayush-shah ayush-shah requested a review from a team as a code owner December 4, 2024 19:51
@notion-workspace Notion Workspace
Copy link

Fivetran filtering using name instead of id

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Dec 4, 2024
ulixius9
ulixius9 previously approved these changes Dec 4, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ayush-shah ayush-shah merged commit 8664c8d into main Dec 5, 2024
18 of 22 checks passed
@ayush-shah ayush-shah deleted the fix-fivetran-filter branch December 5, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulixius9 ulixius9 ulixius9 approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayush-shah @ulixius9