Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes GEN-2199: Allow Fivetran filtering of pipelines using name instead of id #18929

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Fixes GEN-2199: Allow Fivetran filtering of pipelines using name instead of id #18929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec87078
feat(pipeline): support pipeline display names in Fivetran source fil…
ayush-shah Dec 4, 2024
6ae4c12
fix: failing tests due to filter logic modification
ayush-shah Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ingestion/src/metadata/ingestion/source/pipeline/fivetran/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def get_pipelines_list(self) -> Iterable[FivetranPipelineDetails]:
)

def get_pipeline_name(self, pipeline_details: FivetranPipelineDetails) -> str:
return pipeline_details.pipeline_name
return pipeline_details.pipeline_display_name or pipeline_details.pipeline_name

def get_source_url(
self,
Expand Down
2 changes: 1 addition & 1 deletion ingestion/tests/unit/topology/pipeline/test_fivetran.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def test_pipeline_list(self):
def test_pipeline_name(self):
assert (
self.fivetran.get_pipeline_name(EXPECTED_FIVETRAN_DETAILS)
== f'{mock_data.get("group").get("id")}_{mock_data.get("source").get("id")}'
== f'{mock_data.get("group").get("name")} <> {mock_data.get("source").get("schema")}'
)

def test_pipelines(self):
Expand Down
5 changes: 5 additions & 0 deletions ...metadata-docs/content/partials/v1.6/deployment/upgrade/upgrade-prerequisites.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,8 @@ The `ServiceSpec` class serves as the entrypoint for the connector and holds the
to ingest and process the metadata from the source.
You can see [postgres](https://github.com/open-metadata/OpenMetadata/blob/main/ingestion/src/metadata/ingestion/source/database/postgres/service_spec.py) for an
implementation example.


### Fivetran

The filtering of Fivetran pipelines now supports using their names instead of IDs. This change may affect existing configurations that rely on pipeline IDs for filtering.
Loading