Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-3790: Remove unnecessary public modifiers in tests #6222

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

restnek
Copy link
Contributor

@restnek restnek commented Jul 20, 2022

Describe your changes :

Fix sonar issues
Remove public modifiers from test classes and methods where it's possible

Type of change :

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@sureshms
@open-metadata/backend

@restnek restnek temporarily deployed to cypress July 20, 2022 08:56 Inactive
@restnek restnek temporarily deployed to cypress July 20, 2022 08:56 Inactive
@sonarqubecloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cypress
Copy link

cypress bot commented Jul 20, 2022



Test summary

47 0 3 0


Run details

Project openmetadata
Status Passed
Commit eff879c
Started Jul 20, 2022 9:15 AM
Ended Jul 20, 2022 9:28 AM
Duration 12:39 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@TeddyCr TeddyCr requested a review from a team July 20, 2022 09:33
@sonarqubecloud
Copy link

[OpenMetadata-catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

78.8% 78.8% Coverage
0.7% 0.7% Duplication

@mohityadav766 mohityadav766 merged commit 41d0c18 into open-metadata:main Jul 22, 2022
@sureshms
Copy link
Contributor

@restnek thank you for the contribution. First of many to come ❤️ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants