Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-3790: Remove unnecessary public modifiers in tests #6222

Merged
merged 1 commit into from
Jul 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
import org.openmetadata.catalog.exception.PipelineServiceClientException;

@ExtendWith(MockitoExtension.class)
public class AirflowRESTClientIntegrationTest {
class AirflowRESTClientIntegrationTest {

private static final String DAG_NAME = "test_dag";
private static final String URI_TO_HANDLE_REQUEST = "/";
Expand All @@ -57,7 +57,7 @@ void setUp() {
}

@Test
public void testLastIngestionLogsAreRetrievedWhenStatusCodesAre200() {
void testLastIngestionLogsAreRetrievedWhenStatusCodesAre200() {
Map<String, String> expectedMap = Map.of("key1", "value1", "key2", "value2");

registerMockedEndpoints(200, 200);
Expand All @@ -66,7 +66,7 @@ public void testLastIngestionLogsAreRetrievedWhenStatusCodesAre200() {
}

@Test
public void testLastIngestionLogsExceptionWhenLoginFails() {
void testLastIngestionLogsExceptionWhenLoginFails() {
registerMockedEndpoints(404, 200);

Exception exception =
Expand All @@ -80,7 +80,7 @@ public void testLastIngestionLogsExceptionWhenLoginFails() {
}

@Test
public void testLastIngestionLogsExceptionWhenStatusCode404() {
void testLastIngestionLogsExceptionWhenStatusCode404() {
registerMockedEndpoints(200, 404);

Exception exception =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import org.openmetadata.catalog.resources.teams.UserResourceTest;
import org.openmetadata.catalog.type.EntityReference;

public class BotResourceTest extends EntityResourceTest<Bot, CreateBot> {
class BotResourceTest extends EntityResourceTest<Bot, CreateBot> {
public static User botUser;
public static EntityReference botUserRef;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

@Slf4j
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
public class DatabaseSchemaResourceTest extends EntityResourceTest<DatabaseSchema, CreateDatabaseSchema> {
class DatabaseSchemaResourceTest extends EntityResourceTest<DatabaseSchema, CreateDatabaseSchema> {
public DatabaseSchemaResourceTest() {
super(
Entity.DATABASE_SCHEMA,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import org.junit.jupiter.api.Test;
import org.openmetadata.catalog.resources.feeds.MessageParser.EntityLink;

public class MessageParserTest {
class MessageParserTest {
@Test
void parseMessage() {
String s =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public void post_entityCreateWithInvalidName_400() {
}

@Test
public void put_customProperty_200() throws HttpResponseException {
void put_customProperty_200() throws HttpResponseException {
Type tableEntity = getEntityByName("table", "customProperties", ADMIN_AUTH_HEADERS);
assertTrue(listOrEmpty(tableEntity.getCustomProperties()).isEmpty());

Expand All @@ -108,7 +108,7 @@ public void put_customProperty_200() throws HttpResponseException {
}

@Test
public void put_customPropertyToPropertyType_4xx() {
void put_customPropertyToPropertyType_4xx() {
// Adding a custom property to a property type is not allowed (only entity type is allowed)
CustomProperty field =
new CustomProperty().withName("intA").withDescription("intA").withPropertyType(INT_TYPE.getEntityReference());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@

@Slf4j
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
public class MlModelResourceTest extends EntityResourceTest<MlModel, CreateMlModel> {
class MlModelResourceTest extends EntityResourceTest<MlModel, CreateMlModel> {

public static final String ALGORITHM = "regression";
public static Dashboard DASHBOARD;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ void patch_PolicyAttributes_200_ok(TestInfo test) throws IOException {
}

@Test
public void get_policyResources() throws HttpResponseException {
void get_policyResources() throws HttpResponseException {
// Get list of policy resources and make sure it has all the entities and other resources
List<String> resources = getPolicyResources(ADMIN_AUTH_HEADERS);
List<String> entities = Entity.listEntities();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

@Slf4j
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
public class JWTTokenGeneratorTest {
class JWTTokenGeneratorTest {
protected static final String rsaPrivateKeyPath = ResourceHelpers.resourceFilePath("private_key.der");
protected static final String rsaPublicKeyPath = ResourceHelpers.resourceFilePath("public_key.der");
protected JWTTokenConfiguration jwtTokenConfiguration;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import java.util.Set;
import org.junit.jupiter.api.Test;

public class TypeUtilTest {
class TypeUtilTest {
private static final String customAttributes;
private static final ObjectMapper mapper = new ObjectMapper();

Expand All @@ -24,7 +24,7 @@ public class TypeUtilTest {
}

@Test
public void testTypeValue() throws IOException {
void testTypeValue() throws IOException {
JsonSchema intSchema = JsonUtils.getJsonSchema("{ \"type\" : \"integer\", \"minimum\": 10}");
JsonSchema stringSchema = JsonUtils.getJsonSchema("{ \"type\" : \"string\"}");
JsonNode json = mapper.readTree(customAttributes);
Expand Down