Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp #99] type hints Part C #1604

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Conversation

liangzelong
Copy link
Contributor

@liangzelong liangzelong commented Jan 15, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2023

CLA assistant check
All committers have signed the CLA.

mmedit/models/losses/pixelwise_loss.py Outdated Show resolved Hide resolved
mmedit/models/losses/gan_loss.py Outdated Show resolved Hide resolved
mmedit/models/losses/gan_loss.py Outdated Show resolved Hide resolved
mmedit/models/losses/gan_loss.py Outdated Show resolved Hide resolved
mmedit/models/losses/gan_loss.py Outdated Show resolved Hide resolved
mmedit/models/losses/gan_loss.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 87.91% // Head: 87.92% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (598b7d8) compared to base (ad24a5a).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 598b7d8 differs from pull request most recent head 0f75d94. Consider uploading reports for the commit 0f75d94 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1604      +/-   ##
===========================================
+ Coverage    87.91%   87.92%   +0.01%     
===========================================
  Files          399      399              
  Lines        26024    26050      +26     
  Branches      4048     4048              
===========================================
+ Hits         22879    22905      +26     
  Misses        2240     2240              
  Partials       905      905              
Flag Coverage Δ
unittests 87.92% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/losses/clip_loss.py 93.93% <100.00%> (+0.18%) ⬆️
mmedit/models/losses/composition_loss.py 100.00% <100.00%> (ø)
mmedit/models/losses/face_id_loss.py 100.00% <100.00%> (ø)
mmedit/models/losses/feature_loss.py 95.34% <100.00%> (+0.11%) ⬆️
mmedit/models/losses/gan_loss.py 82.72% <100.00%> (+0.27%) ⬆️
mmedit/models/losses/gradient_loss.py 100.00% <100.00%> (ø)
mmedit/models/losses/loss_comps/clip_loss_comps.py 75.00% <100.00%> (+3.00%) ⬆️
...els/losses/loss_comps/disc_auxiliary_loss_comps.py 87.65% <100.00%> (+0.31%) ⬆️
...dit/models/losses/loss_comps/face_id_loss_comps.py 73.07% <100.00%> (+2.24%) ⬆️
mmedit/models/losses/loss_comps/gan_loss_comps.py 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Z-Fran and others added 2 commits January 16, 2023 16:33
* [Refactor] Refactor fileio

* fix ut

* fix self.backend_args

* fix self.backend_args

* fix self.backend_args

* fix self.backend_args

* fix vis_backend

* fix vis_backend

* fix vis_backend

* fix vis_backend

* fix vis_backend

* fix ut
@LeoXing1996 LeoXing1996 merged commit 671ddb1 into open-mmlab:dev-1.x Jan 16, 2023
@Z-Fran Z-Fran mentioned this pull request Mar 2, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants