Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Request #99

Closed
DanielHaroldLane opened this issue Jul 14, 2020 · 1 comment
Closed

Documentation Request #99

DanielHaroldLane opened this issue Jul 14, 2020 · 1 comment

Comments

@DanielHaroldLane
Copy link

DanielHaroldLane commented Jul 14, 2020

After looking at this unified repository I quite like the new approach being taken on creating a monorepo with all available tools sharing a unified framework.

There is a distinct lack of any documentation that shows real life usage. For example, ESRGAN and EDVR both lack usage examples. Whilst looking at the config code I think that I understand how to train new models. There is no usage guide. There is no documented way of running validation against a large image set and no obvious way to use different data sets other than the project defaults.

In previous repositories for ESRGAN (and other implementations) it was possible to execute test.py with an appropriately configured YAML file for the test. The same is not true here and there is no documentation explaining how to use the utilities!

I'd recommend creating a usage page on the wiki demonstrating how to make use of the pretrained models, etc... for each sub tool. Is this on the roadmap?

Anyway, keep up the good work! This set of tools is a fantastic effort and deserves lots of praise! Cutting edge stuff, keep it up!

@hejm37
Copy link
Collaborator

hejm37 commented Jul 14, 2020

Hi, @DanielHaroldLane. Thank you for letting us be aware of the lack of a clearer documentation!

You can take a look at the GettingStarted page for the basic usage. For example, you can use below command to test a model. If you want to replace your own dataset, you may need to read the code under mmedit/datasets/ and create your own dataset. Also remember to replace the dataset type in model configs (train_dataset_type , val_dataset_type etc.).

# single-gpu testing
python tools/test.py configs/example_config.py work_dirs/example_exp/example_model_20200202.pth --out work_dirs/example_exp/results.pkl

# multi-gpu testing
./tools/dist_test.sh configs/example_config.py work_dirs/example_exp/example_model_20200202.pth --save-path work_dirs/example_exp/results/

We are also working on more concrete tutorials that may serve as a wiki. Thank you for you patient!

@hellock hellock closed this as completed Jul 18, 2020
LeoXing1996 pushed a commit that referenced this issue Dec 14, 2022
* 第一次提交

* 第一次提交

* 第二次提交

* 第三次提交

* 第四次提交,修改 isort

* 第5次提交,isort调整

* 第五次提交,调整isort

* 第6次提交,调整yapf

* 第7次提交,针对部分类型修改

* 第7次提交,针对部分类型修改

* 第7次提交,针对部分类型修改

* 第7次提交,针对部分类型修改

* 第八次提交,根据要求修改部分参数类型和函数返回类型

spearable_conv_module.py参数kernel_size,stride,padding,dilation根据ConvModule的同名参数进行修改类型。resnet.py类ResNet中forward函数返回的类型是list;其他部分根据要求修改

* 第八次提交,yapf调整

* 第九次提交,img_normalize.py部分类型修改

根据tests/test_models/test_base_archs/test_img_normalize.py创建这个class时给的参数rgb_mean和rgb_std的类型,以及mmedit/models/editors/ttsr/lte.py创建这个class的参数vgg_mean和vgg_std的参数类型,修改img_mean 和 img_std的类型

* 第十次提交,修改base_edit_model.py和base_mattor.py部分参数类型

base_edit_model.py函数convert_to_datasample的返回类型修改为List[EditDataSample],因为其返回的变量inputs也是函数的参数,因此将参数inputs的类型也修改为List[EditDataSample];
base_mattor.py的函数convert_to_datasample的返回类型修改为List[EditDataSample]
liangzelong added a commit to liangzelong/mmediting that referenced this issue Jan 14, 2023
liangzelong added a commit to liangzelong/mmediting that referenced this issue Jan 14, 2023
liangzelong added a commit to liangzelong/mmediting that referenced this issue Jan 15, 2023
losses except loss_comps

all losses
liangzelong added a commit to liangzelong/mmediting that referenced this issue Jan 16, 2023
losses except loss_comps

all losses

remove wrong Optional type
liangzelong added a commit to liangzelong/mmediting that referenced this issue Jan 16, 2023
losses except loss_comps

all losses

remove wrong Optional type

Add Optional type hint
liangzelong added a commit to liangzelong/mmediting that referenced this issue Jan 16, 2023
LeoXing1996 pushed a commit that referenced this issue Jan 16, 2023
* [CodeCamp #99] type hints Part C

* face id

Co-authored-by: Z-Fran <49083766+Z-Fran@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants