-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix the bug that the training log and evaluating log are mixed #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
+ Coverage 68.27% 68.40% +0.13%
==========================================
Files 160 160
Lines 10599 10608 +9
Branches 1937 1938 +1
==========================================
+ Hits 7236 7256 +20
+ Misses 2979 2976 -3
+ Partials 384 376 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Junjun2016
reviewed
Aug 9, 2021
ZwwWayne
approved these changes
Aug 11, 2021
dreamerlin
approved these changes
Aug 11, 2021
zhouzaida
changed the title
[Fix] Fix the bug that the training log and evaluating log are mixed
[WIP] Fix the bug that the training log and evaluating log are mixed
Aug 11, 2021
zhouzaida
changed the title
[WIP] Fix the bug that the training log and evaluating log are mixed
[Fix] Fix the bug that the training log and evaluating log are mixed
Aug 11, 2021
This was referenced Aug 11, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Fix the bug that the training log and evaluating log are mixed.
Because the priority of EvalHook is higher than LoggerHook, the training log and the evaluating log are mixed. Therefore, we need to dump the training log and clear it before evaluating log is generated. In addition, this problem will only appear in
IterBasedRunner
whoseself.by_epoch
is False, becauseEpochBasedRunner
whoseself.by_epoch
is True calls_do_evaluate
inafter_train_epoch
stage, and at this stage the training log has been printed, so it will not cause any problem.more details
IterBasedRunner
is used. #1248Modification
Add some lines in
mmcv/runner/hooks/evaluation.py
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist