[Fix] Fix the log error #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 107 107
Lines 5847 5847
Branches 960 960
=======================================
Hits 4992 4992
Misses 673 673
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Fixed #758 |
xvjiarui
approved these changes
Aug 9, 2021
xvjiarui
reviewed
Aug 9, 2021
6 tasks
bowenroom
pushed a commit
to bowenroom/mmsegmentation
that referenced
this pull request
Feb 25, 2022
* set the priority of EvalHook to LOW * add comment for priority change * fix comment
aravind-h-v
pushed a commit
to aravind-h-v/mmsegmentation
that referenced
this pull request
Mar 27, 2023
…#766) * mps: alt. implementation for repeat_interleave * style * Bump mps version of PyTorch in the documentation. * Apply suggestions from code review Co-authored-by: Suraj Patil <surajp815@gmail.com> * Simplify: do not check for device. * style * Fix repeat dimensions: - The unconditional embeddings are always created from a single prompt. - I was shadowing the batch_size var. * Split long lines as suggested by Suraj. Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> Co-authored-by: Suraj Patil <surajp815@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the priority of EvalHook is higher than IterTimerHook, it will cause
KeyError: 'data_time'(#758).Since the
timekey will add to the output of log_buffer after IterTimeHook, the TextLoggerHook will print thetimeanddata_timeat the same time.This PR is based on open-mmlab/mmcv#1252.
Modification
Set the priority of EvalHook to LOW.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
No.