Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add roipoint_pool3d op from mmdet3d #1358

Merged
merged 11 commits into from
Oct 15, 2021

Conversation

DCNSW
Copy link
Contributor

@DCNSW DCNSW commented Sep 22, 2021

Motivation

Add roipoint_pool3d cuda operation from mmdet3d (branch: v1.0.0.dev0).

Modification

Several files in mmcv/ops folder.

BC-breaking (Optional)

No.

Use cases (Optional)

from mmcv.ops import RoIPointPool3d

@zhouzaida zhouzaida added the CUDA label Sep 22, 2021
@zhouzaida zhouzaida mentioned this pull request Sep 24, 2021
29 tasks
@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #1358 (867e073) into master (8cac7c2) will decrease coverage by 0.05%.
The diff coverage is 52.00%.

❗ Current head 867e073 differs from pull request most recent head 81bf861. Consider uploading reports for the commit 81bf861 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1358      +/-   ##
==========================================
- Coverage   68.59%   68.54%   -0.06%     
==========================================
  Files         164      165       +1     
  Lines       10891    10922      +31     
  Branches     1991     1994       +3     
==========================================
+ Hits         7471     7486      +15     
- Misses       3030     3043      +13     
- Partials      390      393       +3     
Flag Coverage Δ
unittests 68.54% <52.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/ops/roipoint_pool3d.py 50.00% <50.00%> (ø)
mmcv/ops/__init__.py 100.00% <100.00%> (ø)
mmcv/runner/dist_utils.py 50.00% <0.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e99bfce...81bf861. Read the comment docs.

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 5c25ae1 into open-mmlab:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants