Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs of create_gt_database #210

Closed
meng-zha opened this issue Nov 30, 2020 · 3 comments
Closed

Bugs of create_gt_database #210

meng-zha opened this issue Nov 30, 2020 · 3 comments

Comments

@meng-zha
Copy link
Contributor

Thanks for the wonderful codebase.

  1. The 'LoadPointsFromFile' pipeline in create_groundtruth_database requires the 'coord_type' arguments.
  2. The 'points' in 'example' is of type 'LiDARPoints' while 'box_np_ops.points_in_rbbox' needs numpy.ndarray.
  3. 'BasePoints._ _ getitem_ _ ' wants to edit the tuple object 'item', which needs to be converted to list first.

I want to know whether these are caused by bugs or my installation problem. The try of PR has been sent, or these can be fixed by a few minutes by yourself.

@meng-zha meng-zha closed this as completed Dec 1, 2020
@songlilucky
Copy link

Thanks for your commit #211 ,but when i create nuscenes gt, i met this

problem:Create GT Database of NuScenesDataset
{'type': 'NuScenesDataset', 'data_root': './data/nuscenes', 'ann_file': './data/nuscenes/nuscenes_infos_train.pkl'}
Traceback (most recent call last):
File "tools/create_data.py", line 226, in
max_sweeps=args.max_sweeps)
File "tools/create_data.py", line 68, in nuscenes_data_prep
f'{out_dir}/{info_prefix}_infos_train.pkl')
File "/mnt/luci-home/songli/mmdet3d/tools/data_converter/create_gt_database.py", line 215, in create_groundtruth_database
dataset = build_dataset(dataset_cfg)
File "/mnt/luci-home/songli/mmdet3d/mmdet3d/datasets/builder.py", line 37, in build_dataset
dataset = build_from_cfg(cfg, DATASETS, default_args)
File "/mnt/3dvision-cpfs/envs/conda/envs/mmdet3d/lib/python3.6/site-packages/mmcv/utils/registry.py", line 171, in build_from_cfg
return obj_cls(**args)
File "/mnt/luci-home/songli/mmdet3d/mmdet3d/datasets/nuscenes_dataset.py", line 127, in init
test_mode=test_mode)
File "/mnt/luci-home/songli/mmdet3d/mmdet3d/datasets/custom_3d.py", line 64, in init
self.pipeline = Compose(pipeline)
File "/mnt/luci-home/songli/mmdet/mmdet/datasets/pipelines/compose.py", line 22, in init
transform = build_from_cfg(transform, PIPELINES)
File "/mnt/3dvision-cpfs/envs/conda/envs/mmdet3d/lib/python3.6/site-packages/mmcv/utils/registry.py", line 171, in build_from_cfg
return obj_cls(**args)
TypeError: init() missing 1 required positional argument: 'coord_type'

@meng-zha
Copy link
Contributor Author

meng-zha commented Dec 8, 2020

@songlilucky I test the kitti dataset before, and I have found that the 'coord_type' should be in the ‘LoadPointsFromFile’ pipeline but not in the 'LoadPointsFromMultiSweeps' pipeline. It is a bug. I will fix it immediately.

@songlilucky
Copy link

@songlilucky I test the kitti dataset before, and I have found that the 'coord_type' should be in the ‘LoadPointsFromFile’ pipeline but not in the 'LoadPointsFromMultiSweeps' pipeline. It is a bug. I will fix it immediately.

Thanks~

tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this issue Sep 5, 2022
* [WIP] Refactor v2.0 (open-mmlab#163)

* Refactor backend wrapper

* Refactor mmdet.inference

* Fix

* merge

* refactor utils

* Use deployer and deploy_model to manage pipeline

* Resolve comments

* Add a real inference api function

* rename wrappers

* Set execute to private method

* Rename deployer deploy_model

* Refactor task

* remove type hint

* lint

* Resolve comments

* resolve comments

* lint

* docstring

* [Fix]: Fix bugs in details in refactor branch (open-mmlab#192)

* [WIP] Refactor v2.0 (open-mmlab#163)

* Refactor backend wrapper

* Refactor mmdet.inference

* Fix

* merge

* refactor utils

* Use deployer and deploy_model to manage pipeline

* Resolve comments

* Add a real inference api function

* rename wrappers

* Set execute to private method

* Rename deployer deploy_model

* Refactor task

* remove type hint

* lint

* Resolve comments

* resolve comments

* lint

* docstring

* Fix errors

* lint

* resolve comments

* fix bugs

* conflict

* lint and typo

* Resolve comment

* refactor mmseg (open-mmlab#201)

* support mmseg

* fix docstring

* fix docstring

* [Refactor]: Get the count of backend files (open-mmlab#202)

* Fix backend files

* resolve comments

* lint

* Fix ncnn

* [Refactor]: Refactor folders of mmdet (open-mmlab#200)

* Move folders

* lint

* test object detection model

* lint

* reset changes

* fix openvino

* resolve comments

* __init__.py

* Fix path

* [Refactor]: move mmseg (open-mmlab#206)

* [Refactor]: Refactor mmedit (open-mmlab#205)

* feature mmedit

* edit2.0

* edit

* refactor mmedit

* fix __init__.py

* fix __init__

* fix formai

* fix comment

* fix comment

* Fix wrong func_name of ConvFCBBoxHead (open-mmlab#209)

* [Refactor]: Refactor mmdet unit test (open-mmlab#207)

* Move folders

* lint

* test object detection model

* lint

* WIP

* remove print

* finish unit test

* Fix tests

* resolve comments

* Add mask test

* lint

* resolve comments

* Refine cfg file

* Move files

* add files

* Fix path

* [Unittest]: Refine the unit tests in mmdet open-mmlab#214

* [Refactor] refactor mmocr to mmdeploy/codebase (open-mmlab#213)

* refactor mmocr to mmdeploy/codebase

* fix docstring of show_result

* fix docstring of visualize

* refine docstring

* replace print with logging

* refince codes

* resolve comments

* resolve comments

* [Refactor]: mmseg  tests (open-mmlab#210)

* refactor mmseg tests

* rename test_codebase

* update

* add model.py

* fix

* [Refactor] Refactor mmcls and the package (open-mmlab#217)

* refactor mmcls

* fix yapf

* fix isort

* refactor-mmcls-package

* fix print to logging

* fix docstrings according to others comments

* fix comments

* fix comments

* fix allentdans comment in pr215

* remove mmocr init

* [Refactor] Refactor mmedit tests (open-mmlab#212)

* feature mmedit

* edit2.0

* edit

* refactor mmedit

* fix __init__.py

* fix __init__

* fix formai

* fix comment

* fix comment

* buff

* edit test and code refactor

* refactor dir

* refactor tests/mmedit

* fix docstring

* add test coverage

* fix lint

* fix comment

* fix comment

* Update typehint (open-mmlab#216)

* update type hint

* update docstring

* update

* remove file

* fix ppl

* Refine get_predefined_partition_cfg

* fix tensorrt version > 8

* move parse_cuda_device_id to device.py

* Fix cascade

* onnx2ncnn docstring

Co-authored-by: Yifan Zhou <singlezombie@163.com>
Co-authored-by: RunningLeon <maningsheng@sensetime.com>
Co-authored-by: VVsssssk <88368822+VVsssssk@users.noreply.github.com>
Co-authored-by: AllentDan <41138331+AllentDan@users.noreply.github.com>
Co-authored-by: hanrui1sensetime <83800577+hanrui1sensetime@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants