Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: create_gt_database #211

Merged
merged 1 commit into from
Dec 1, 2020
Merged

[Fix]: create_gt_database #211

merged 1 commit into from
Dec 1, 2020

Conversation

meng-zha
Copy link
Contributor

  • Fix bugs for the create_gt_database of kitti

  • Fix bugs for 'get_item' of BasePoints

* Fix bugs for the create_gt_database of kitti

* Fix bugs for '__get_item__' of BasePoints
@CLAassistant
Copy link

CLAassistant commented Nov 30, 2020

CLA assistant check
All committers have signed the CLA.

@ZwwWayne
Copy link
Collaborator

Hi @meng-zha ,
Thanks for your kind contribution. Would you like to sing the CLA thus we could merge this PR?

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #211 (34ec763) into master (93dc5df) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   49.94%   49.93%   -0.01%     
==========================================
  Files         172      172              
  Lines       11554    11556       +2     
  Branches     1801     1801              
==========================================
  Hits         5771     5771              
- Misses       5409     5411       +2     
  Partials      374      374              
Flag Coverage Δ
unittests 49.93% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/points/base_points.py 65.90% <0.00%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93dc5df...6b15363. Read the comment docs.

@meng-zha
Copy link
Contributor Author

Hi @meng-zha ,
Thanks for your kind contribution. Would you like to sing the CLA thus we could merge this PR?

Of course.:hugs: I have signed the CLA.

@ZwwWayne ZwwWayne merged commit 2b635d2 into open-mmlab:master Dec 1, 2020
@meng-zha meng-zha deleted the dev branch December 2, 2020 06:14
meng-zha added a commit to meng-zha/mmdetection3d that referenced this pull request Dec 8, 2020
* Fix the bug on the commit open-mmlab#211 for the create_gt_database in nuscenes
ZwwWayne pushed a commit that referenced this pull request Dec 9, 2020
* Fix the bug on the commit #211 for the create_gt_database in nuscenes
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* first

* Add get_started.md

* update readme

* Apply suggestions from code review

Co-authored-by: AllentDan <41138331+AllentDan@users.noreply.github.com>

* add how to find path

* fix for comment

* an -> a

Co-authored-by: AllentDan <41138331+AllentDan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants