Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible bug in indoor_eval #230

Closed
filaPro opened this issue Dec 12, 2020 · 1 comment · Fixed by #231
Closed

possible bug in indoor_eval #230

filaPro opened this issue Dec 12, 2020 · 1 comment · Fixed by #231
Assignees
@Tai-Wang
Labels
bug Something isn't working

Comments

@filaPro
Copy link
Contributor

filaPro commented Dec 12, 2020

Looks like eval_map_recall function is incorrect in case of gt.keys() != pred.keys().
For example if gt.keys() == [2, 4] and pred.keys() == [4] then len(ret_values) == 1 and when i == 1 we get RuntimeError in ret_values[i].
If you also think it is a bug, i can make a pull request to fix it.
@ZwwWayne
Copy link
Collaborator

Hi @filaPro ，
Thanks for your kind suggestion. It seems like a bug. PRs are definitely welcomed.

@ZwwWayne ZwwWayne added the bug Something isn't working label Dec 13, 2020
@filaPro filaPro mentioned this issue Dec 13, 2020
Merged
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this issue Sep 5, 2022
@SingleZombie
Fix bug (open-mmlab#230)
64ee8db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tai-Wang Tai-Wang

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix indoor_eval in case of less classes in prediction
3 participants
@filaPro @Tai-Wang @ZwwWayne