Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix indoor_eval in case of less classes in prediction #231

Merged
merged 2 commits into from
Dec 16, 2020
Merged

fix indoor_eval in case of less classes in prediction #231

merged 2 commits into from
Dec 16, 2020

Conversation

filaPro
Copy link
Contributor

@filaPro filaPro commented Dec 13, 2020

Fixes #230.

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 13, 2020

Codecov Report

Merging #231 (d4f186e) into master (bafee2e) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   49.94%   49.94%           
=======================================
  Files         172      172           
  Lines       11558    11558           
  Branches     1801     1801           
=======================================
  Hits         5773     5773           
  Misses       5411     5411           
  Partials      374      374           
Flag Coverage Δ
unittests 49.94% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/evaluation/indoor_eval.py 10.67% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bafee2e...caf24ba. Read the comment docs.

@Tai-Wang Tai-Wang self-requested a review December 14, 2020 02:52
Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please notice messages from linting. You can pre-commit to check whether there is any problem in terms of format.

@filaPro
Copy link
Contributor Author

filaPro commented Dec 14, 2020

Hi @Tai-Wang,

I've fixed yapf warnings. However I have one more question. What is the idea behind origin=(0.5, 0.5, 0.5) here? Looks like this function deals with gt and pred in terms of DepthInstance3DBoxes with default origin == (0.5, 0.5, 0.0). But in this line you only shift gt along z axis and don't modify z coordinate of pred. Is this the expected behavour?

@ZwwWayne ZwwWayne merged commit 2d0b771 into open-mmlab:master Dec 16, 2020
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* fix apis unit test

* remove tmp file

* delete test/test_mmedit and tests/test_mmseg
 Please enter the commit message for your changes. Lines starting

* fix device to cpu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

possible bug in indoor_eval
4 participants