Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] update Det3DLocalVisualization and visualization documentation #1857

Merged
merged 12 commits into from
Oct 12, 2022

Conversation

ZCMax
Copy link
Collaborator

@ZCMax ZCMax commented Sep 20, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  • Support BEV visualization for 3D boxes
  • Update the projected 3D boxes visualization logics and beautify the visualization effects
  • Update visualization.md
  • add visualizer in dataset config for visualization
  • add draw_points_on_image function to visualize the projected points on image

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZCMax ZCMax added the 1.x label Sep 21, 2022
docs/en/user_guides/visualization.md Outdated Show resolved Hide resolved
docs/en/user_guides/visualization.md Outdated Show resolved Hide resolved
mmdet3d/visualization/local_visualizer.py Outdated Show resolved Hide resolved
python tools/misc/browse_dataset.py configs/_base_/datasets/kitti-3d-3class.py --task det --aug --output-dir ${OUTPUT_DIR} --online
```

If you also want to show 2D images with 3D bounding boxes projected onto them, you need to find a config that supports multi-modality data loading, and then change the `--task` args to `multi_modality-det`. An example is showed below
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that If you also want to show 2D images with 3D bounding boxes projected onto them, you need to find a config that supports multi-modality data loading

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it's quite normal, we need a config where input_modality = dict(use_lidar=True, use_camera=True), typically the 3d point cloud algorithm config has input_modality = dict(use_lidar=True, use_camera=False)

@ZCMax ZCMax changed the title [Refactor] update visualization documentation [WIP][Refactor] update visualization documentation Sep 21, 2022
@ZCMax ZCMax changed the title [WIP][Refactor] update visualization documentation [WIP][Refactor] update Det3DLocalVisualization and visualization documentation Sep 27, 2022
@ZCMax ZCMax requested a review from VVsssssk September 27, 2022 13:45
@ZCMax ZCMax changed the title [WIP][Refactor] update Det3DLocalVisualization and visualization documentation [Refactor] update Det3DLocalVisualization and visualization documentation Sep 28, 2022
@Tai-Wang Tai-Wang merged commit 25e3801 into open-mmlab:dev-1.x Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants