Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update gather model script #1917

Open
wants to merge 3 commits into
base: dev-1.0
Choose a base branch
from

Conversation

ZCMax
Copy link
Collaborator

@ZCMax ZCMax commented Oct 13, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Update gather model script to keep in line with mmdetection

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZCMax ZCMax requested a review from Tai-Wang October 13, 2022 10:01
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 49.96% // Head: 49.56% // Decreases project coverage by -0.40% ⚠️

Coverage data is based on head (064c4f3) compared to base (56acaf3).
Patch has no changes to coverable lines.

❗ Current head 064c4f3 differs from pull request most recent head 4a72d1f. Consider uploading reports for the commit 4a72d1f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1917      +/-   ##
==========================================
- Coverage   49.96%   49.56%   -0.41%     
==========================================
  Files         228      227       -1     
  Lines       19916    19708     -208     
  Branches     3187     3160      -27     
==========================================
- Hits         9952     9769     -183     
+ Misses       9374     9352      -22     
+ Partials      590      587       -3     
Flag Coverage Δ
unittests 49.56% <ø> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...3d/core/bbox/samplers/iou_neg_piecewise_sampler.py 20.25% <0.00%> (-1.00%) ⬇️
mmdet3d/models/roi_heads/point_rcnn_roi_head.py 25.96% <0.00%> (-0.71%) ⬇️
...odels/roi_heads/bbox_heads/point_rcnn_bbox_head.py 30.18% <0.00%> (-0.14%) ⬇️
mmdet3d/apis/inference.py 41.34% <0.00%> (ø)
mmdet3d/datasets/__init__.py 100.00% <0.00%> (ø)
mmdet3d/models/necks/__init__.py 100.00% <0.00%> (ø)
mmdet3d/datasets/pipelines/__init__.py 100.00% <0.00%> (ø)
mmdet3d/models/necks/view_transformer.py
mmdet3d/datasets/pipelines/transforms_3d.py 87.39% <0.00%> (+1.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tai-Wang Tai-Wang changed the title [Fix] Update gather model script [Fix] Update gather model script and CenterPoint models Oct 17, 2022
@Tai-Wang Tai-Wang changed the title [Fix] Update gather model script and CenterPoint models [Fix] Update gather model script Oct 17, 2022
@ZCMax ZCMax requested a review from Tai-Wang November 24, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants