Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update all the metafiles #2006

Merged
merged 13 commits into from
Dec 2, 2022
Merged

Conversation

JingweiZhang12
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@JingweiZhang12 JingweiZhang12 requested review from VVsssssk and removed request for ZCMax and VVsssssk November 17, 2022 05:55
@ZCMax
Copy link
Collaborator

ZCMax commented Nov 18, 2022

Please update centerpoint according to this PR #1917, we update the centerpoint checkpoint link

@JingweiZhang12 JingweiZhang12 requested review from ZCMax and VVsssssk and removed request for VVsssssk November 21, 2022 06:30
@JingweiZhang12 JingweiZhang12 requested review from VVsssssk and ZCMax and removed request for ZCMax and VVsssssk November 21, 2022 11:24
configs/centerpoint/metafile.yml Outdated Show resolved Hide resolved
configs/parta2/metafile.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev-1.x@f376fa8). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-1.x    #2006   +/-   ##
==========================================
  Coverage           ?   45.27%           
==========================================
  Files              ?      255           
  Lines              ?    20831           
  Branches           ?     3291           
==========================================
  Hits               ?     9431           
  Misses             ?    10780           
  Partials           ?      620           
Flag Coverage Δ
unittests 45.27% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JingweiZhang12
Copy link
Contributor Author

Ready to be merged.

@JingweiZhang12 JingweiZhang12 requested review from ZwwWayne and removed request for Tai-Wang December 2, 2022 06:06
@ZwwWayne ZwwWayne merged commit 5489875 into open-mmlab:dev-1.x Dec 2, 2022
ZwwWayne pushed a commit to ZwwWayne/mmdetection3d that referenced this pull request Dec 3, 2022
* update centerpoint, dgcnn, fcos3d and free_anchor metafile

* check all metafile in configs

* update centerpoint, pointpillars and second yml

* rename PartA2 to parta2 in the name of config

* update metafile in nuimages

* update readme in nuimages
ZwwWayne pushed a commit to ZwwWayne/mmdetection3d that referenced this pull request Dec 3, 2022
* update centerpoint, dgcnn, fcos3d and free_anchor metafile

* check all metafile in configs

* update centerpoint, pointpillars and second yml

* rename PartA2 to parta2 in the name of config

* update metafile in nuimages

* update readme in nuimages
@JingweiZhang12 JingweiZhang12 deleted the fix_yml branch January 11, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants