Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Spvcnn backbone #2320

Merged
merged 93 commits into from
Mar 28, 2023
Merged

[Feature] Spvcnn backbone #2320

merged 93 commits into from
Mar 28, 2023

Conversation

sunjiahao1999
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add spvcnn backbone.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 16.16% and project coverage change: -0.14 ⚠️

Comparison is base (ee6cc04) 47.16% compared to head (a8e4157) 47.03%.

❗ Current head a8e4157 differs from pull request most recent head 445f58a. Consider uploading reports for the commit 445f58a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2320      +/-   ##
===========================================
- Coverage    47.16%   47.03%   -0.14%     
===========================================
  Files          273      274       +1     
  Lines        22665    22764      +99     
  Branches      3535     3544       +9     
===========================================
+ Hits         10690    10706      +16     
- Misses       11294    11376      +82     
- Partials       681      682       +1     
Flag Coverage Δ
unittests 47.03% <16.16%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/backbones/spvcnn_backone.py 15.30% <15.30%> (ø)
mmdet3d/models/backbones/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mmdet3d/models/backbones/spvcnn_backone.py Outdated Show resolved Hide resolved
mmdet3d/models/backbones/spvcnn_backone.py Outdated Show resolved Hide resolved
mmdet3d/models/backbones/spvcnn_backone.py Outdated Show resolved Hide resolved
mmdet3d/models/data_preprocessors/data_preprocessor.py Outdated Show resolved Hide resolved
mmdet3d/models/backbones/spvcnn_backone.py Outdated Show resolved Hide resolved
mmdet3d/models/backbones/spvcnn_backone.py Outdated Show resolved Hide resolved
mmdet3d/models/backbones/spvcnn_backone.py Outdated Show resolved Hide resolved
mmdet3d/models/backbones/spvcnn_backone.py Outdated Show resolved Hide resolved
mmdet3d/models/backbones/spvcnn_backone.py Outdated Show resolved Hide resolved
mmdet3d/models/backbones/spvcnn_backone.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit 98d2642 into open-mmlab:dev-1.x Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants