[Enhance] Move train_cfg test_cfg to model #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
=======================================
Coverage 50.23% 50.24%
=======================================
Files 173 173
Lines 11585 11591 +6
Branches 1803 1804 +1
=======================================
+ Hits 5820 5824 +4
- Misses 5404 5405 +1
- Partials 361 362 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Tai-Wang
approved these changes
Feb 18, 2021
ZwwWayne
reviewed
Feb 19, 2021
| point_cloud_range = [-54, -54, -5.0, 54, 54, 3.0] | ||
|
|
||
| model = dict( | ||
| pts_voxel_layer=dict( |
ZwwWayne
reviewed
Feb 19, 2021
| model = dict( | ||
| pts_voxel_layer=dict( |
ZwwWayne
reviewed
Feb 19, 2021
| point_cloud_range = [-51.2, -51.2, -5.0, 51.2, 51.2, 3.0] | ||
|
|
||
| model = dict( | ||
| pts_voxel_layer=dict(point_cloud_range=point_cloud_range), |
|
Please also modify the documentation. |
ZwwWayne
reviewed
Feb 21, 2021
tools/train.py
Outdated
| @@ -136,7 +136,7 @@ def main(): | |||
| meta['seed'] = args.seed | |||
|
|
|||
| model = build_detector( | |||
| cfg.model, train_cfg=cfg.train_cfg, test_cfg=cfg.test_cfg) | |||
| cfg.model, train_cfg=cfg.model.train_cfg, test_cfg=cfg.model.test_cfg) | |||
There was a problem hiding this comment.
We should directly use cfg.model without setting train_cfg and test_cfg, see here.
|
Add migration section for the config refactoring like here. |
ZwwWayne
requested changes
Feb 23, 2021
ZwwWayne
approved these changes
Feb 23, 2021
tpoisonooo
pushed a commit
to tpoisonooo/mmdetection3d
that referenced
this pull request
Sep 5, 2022
* fix DataContainer case for get_tensor_from_input * fix docstring
tpoisonooo
pushed a commit
to tpoisonooo/mmdetection3d
that referenced
this pull request
Sep 5, 2022
tpoisonooo
added a commit
to tpoisonooo/mmdetection3d
that referenced
this pull request
Sep 5, 2022
* fix pose demo and windows build (open-mmlab#307) * init * Update nms_rotated.cpp * add postprocessing_masks gpu version (open-mmlab#276) * add postprocessing_masks gpu version * default device cpu * pre-commit fix Co-authored-by: hadoop-basecv <hadoop-basecv@set-gh-basecv-serving-classify11.mt> * fixed a bug causes text-recognizer to fail when (non-NULL) empty bboxes list is passed (open-mmlab#310) * [Fix] include missing <type_traits> for formatter.h (open-mmlab#313) * fix formatter * relax GCC version requirement * fix * fix lint * fix lint * [Fix] MMEditing cannot save results when testing (open-mmlab#336) * fix show * lint * remove redundant codes * resolve comment * type hint * docs(build): fix typo (open-mmlab#352) * docs(build): add missing build option * docs(build): add onnx install * style(doc): trim whitespace * docs(build): revert install onnx * docs(build): add ncnn LD_LIBRARY_PATH * docs(build): fix path error * fix openvino export tmp model, add binary flag (open-mmlab#353) * init circleci (open-mmlab#348) * fix wrong input mat type (open-mmlab#362) * fix wrong input mat type * fix lint * fix(docs): remove redundant doc tree (open-mmlab#360) * fix missing ncnn_DIR & InferenceEngine_DIR (open-mmlab#364) * update doc Co-authored-by: Chen Xin <xinchen.tju@gmail.com> Co-authored-by: Shengxi Li <982783556@qq.com> Co-authored-by: hadoop-basecv <hadoop-basecv@set-gh-basecv-serving-classify11.mt> Co-authored-by: lzhangzz <lzhang329@gmail.com> Co-authored-by: Yifan Zhou <singlezombie@163.com> Co-authored-by: tpoisonooo <khj.application@aliyun.com> Co-authored-by: lvhan028 <lvhan_028@163.com>
tpoisonooo
pushed a commit
to tpoisonooo/mmdetection3d
that referenced
this pull request
Sep 5, 2022
* init * add doc * add * Update test_ops.py * fix bug * fix pose demo and windows build (open-mmlab#307) * add postprocessing_masks gpu version (open-mmlab#276) * add postprocessing_masks gpu version * default device cpu * pre-commit fix Co-authored-by: hadoop-basecv <hadoop-basecv@set-gh-basecv-serving-classify11.mt> * fixed a bug causes text-recognizer to fail when (non-NULL) empty bboxes list is passed (open-mmlab#310) * [Fix] include missing <type_traits> for formatter.h (open-mmlab#313) * fix formatter * relax GCC version requirement * fix lint * Update onnxruntime.md * fix lint Co-authored-by: Chen Xin <xinchen.tju@gmail.com> Co-authored-by: Shengxi Li <982783556@qq.com> Co-authored-by: hadoop-basecv <hadoop-basecv@set-gh-basecv-serving-classify11.mt> Co-authored-by: lzhangzz <lzhang329@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move train_cfg/test_cfg into model in model configs