Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix issue #305 #311

Closed
wants to merge 5 commits into from
Closed

Conversation

yezhen17
Copy link
Collaborator

@yezhen17 yezhen17 commented Feb 18, 2021

The bug mentioned in issue #305 is caused by a discordance between the current cuda device and the device of the input tensors. This may potentially cause unexpected behaviours in other cuda ops.

@yezhen17 yezhen17 changed the title Fix issue #305 [Fix] Fix issue #305 Feb 18, 2021
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #311 (df57552) into master (ac9a3e8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   50.23%   50.23%           
=======================================
  Files         173      173           
  Lines       11585    11585           
  Branches     1803     1803           
=======================================
  Hits         5820     5820           
  Misses       5404     5404           
  Partials      361      361           
Flag Coverage Δ
unittests 50.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/fusion_layers/point_fusion.py 37.62% <ø> (ø)
mmdet3d/models/dense_heads/centerpoint_head.py 47.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5592a50...df57552. Read the comment docs.

@ZwwWayne
Copy link
Collaborator

Can we use the pytorch API https://pytorch.org/docs/stable/cuda.html#torch.cuda.set_device rather than modifying the CUDA code?

@yezhen17 yezhen17 closed this Feb 23, 2021
@yezhen17 yezhen17 deleted the fix_issue_305 branch February 23, 2021 07:39
@yezhen17 yezhen17 mentioned this pull request Feb 23, 2021
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants