Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix issue #305 #317

Merged
merged 7 commits into from
Feb 24, 2021
Merged

[Fix] Fix issue #305 #317

merged 7 commits into from
Feb 24, 2021

Conversation

yezhen17
Copy link
Collaborator

Reopen pr to fix 305 using torch.cuda API

@yezhen17
Copy link
Collaborator Author

yezhen17 commented Feb 23, 2021 •
edited
Loading

Update on #311 (closed accidentally).

@yezhen17 yezhen17 changed the title [Fix] Fix issue 305 [Fix] Fix issue #305 Feb 23, 2021
@codecov
Copy link

codecov bot commented Feb 23, 2021 •
edited
Loading

Codecov Report

Merging #317 (74b3d61) into master (ac9a3e8) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
- Coverage   50.23%   50.21%   -0.03%     
==========================================
  Files         173      173              
  Lines       11585    11599      +14     
  Branches     1803     1806       +3     
==========================================
+ Hits         5820     5824       +4     
- Misses       5404     5413       +9     
- Partials      361      362       +1
Flag Coverage Δ
unittests 50.21% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/fusion_layers/point_fusion.py 37.62% <ø> (ø)
mmdet3d/ops/roiaware_pool3d/points_in_boxes.py 32.25% <0.00%> (-11.23%) ⬇️
mmdet3d/models/dense_heads/centerpoint_head.py 47.01% <100.00%> (ø)
mmdet3d/models/builder.py 88.88% <0.00%> (-6.57%) ⬇️
mmdet3d/apis/inference.py 60.71% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5592a50...74b3d61. Read the comment docs.

@yezhen17 yezhen17 linked an issue Feb 24, 2021 that may be closed by this pull request
Question on points_in_boxes_gpu #305
Closed
@ZwwWayne ZwwWayne merged commit bdeacec into open-mmlab:master Feb 24, 2021
@yezhen17 yezhen17 deleted the fix_issue_305 branch March 13, 2021 06:07
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
@VVsssssk
【Docs】Fix docs about codebase (open-mmlab#317)
fce37d4 
* fix codebase docs

* fix edit

* fix mmcls docs

* fix docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZwwWayne ZwwWayne ZwwWayne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question on points_in_boxes_gpu
2 participants
@yezhen17 @ZwwWayne