Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] VoteNet refactor #322

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

yezhen17
Copy link
Collaborator

Modified backbone feature extraction in order that ImVoteNet can directly use VoteHead.

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #322 (b9c3253) into imvotenet (824b85a) will decrease coverage by 0.02%.
The diff coverage is 8.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##           imvotenet     #322      +/-   ##
=============================================
- Coverage      50.06%   50.03%   -0.03%     
=============================================
  Files            175      175              
  Lines          11794    11803       +9     
  Branches        1853     1854       +1     
=============================================
+ Hits            5905     5906       +1     
- Misses          5507     5515       +8     
  Partials         382      382              
Flag Coverage Δ
unittests 50.03% <8.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/dense_heads/vote_head.py 22.35% <0.00%> (ø)
mmdet3d/models/detectors/votenet.py 28.57% <11.11%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 824b85a...b9c3253. Read the comment docs.

@yezhen17
Copy link
Collaborator Author

Made sure the performance was unaffected

@ZwwWayne ZwwWayne merged commit 01ff7a6 into open-mmlab:imvotenet Mar 1, 2021
@yezhen17 yezhen17 deleted the votenet_refactor branch March 13, 2021 06:07
ZwwWayne added a commit that referenced this pull request Mar 24, 2021
* Added image loading in SUNRGB-D dataset (#195)

* image loading

* format and docstring fix

* removed irrelevant files

* removed irrelevant files

* load image only if modality is pc+img

* added modality like nuscenes

* Added imvotenet image branch pretrain (#217)

* image loading

* naive commit

* format and docstring fix

* removed irrelevant files

* removed irrelevant files

* load image only if modality is pc+img

* added modality like nuscenes

* pretrain_2d_model

* finetune sunrgbd

* finetune sunrgbd

* deleted unused code

* fixed a bug

* resolve conflict

* update config file

* fix docstring and configs

* integrated vote fusion

* coords transform and unit test

* Update docstring

* refactor and add unit test

* fix bug caused by mmcv upgrade; delete pdb breakpoint

* add point fusion unittest

* remove unused file

* fix typos

* updates

* add assertion info

* update

* add unittest

* add vote fusion unittest

* add vote fusion unittest

* [Refactor] VoteNet refactor (#322)

* votenet refactor

* remove file

* minor update

* docstring

* initial update of imvotenet

* [Feature] Support vote fusion (#297)

* integrated vote fusion

* coords transform and unit test

* Update docstring

* refactor and add unit test

* add point fusion unittest

* remove unused file

* updates

* add assertion info

* update

* add unittest

* add vote fusion unittest

* add vote fusion unittest

* minor update

* docstring

* change np ops to torch

* refactor test

* update

* refactor of image mlp and np random ops to torch

* add docstring

* add config and mod dataset

* fix bugs

* add_comments

* fix bugs

* fix_bug

* fix bug

* fix bug

* fix bug

* fix bug

* final fix

* fix bug

* ?

* add docstring

* move train/test cfg

* change img mlp default param

* rename config

* minor mod

* change config name

* move train/test cfg

* some fixes and 2d utils

* fix config name

* fix config override issue

* config simplify & reformat

* explicitly set eval mode->override train()

* add fix_img_branch to config

* remove set_img_branch_eval_mode

* temporal fix, change calibs to calib

* more docstring and view/reshape, expand/repeat change

* complete imvotenet docstring

* fix docstring

* add config and some minor fix

* rename config

Co-authored-by: ZwwWayne <wayne.zw@outlook.com>
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* refine chniese readme

* fix lint

* update logo, features and acknowledgement

* add qrcode url

Co-authored-by: lvhan028 <lvhan_028@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants