-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Add waymo unit test #455
Conversation
3b8ebc2
to
f63e822
Compare
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
+ Coverage 50.55% 50.67% +0.11%
==========================================
Files 189 189
Lines 14453 14453
Branches 2366 2366
==========================================
+ Hits 7307 7324 +17
+ Misses 6655 6636 -19
- Partials 491 493 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
c32df5b
to
7088565
Compare
The file sizes for unit tests are too big. We need to make the size of test data smaller. See other files for unit test. |
Yes I have made them smaller (each <1MB). |
4d811dd
to
1737063
Compare
I have some trouble in the Waymo protocol testing of The predicted bbox after conversion:
The loaded
|
Sometimes evaluation methods of these datasets may not deal with all the corner cases. You may try to validate it with more samples or add some noises to these predictions. |
1737063
to
83b99f2
Compare
I finally solved the problem and this PR is ready for review now @ZwwWayne! |
5beb972
to
1e826a8
Compare
1e826a8
to
07d0933
Compare
Fix issue#447. I add some basic unit tests for WaymoDataset. Mainly about
getitem
andshow
(because I want to check its compatibility in dataset_browse). I am not familiar with Waymo format of box and itsevaluate
function. Maybe someone can help me continue this PR?