Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modules before mg_head in centerpoint #46

Merged
merged 15 commits into from
Aug 18, 2020

Conversation

yinchimaoliang
Copy link
Contributor

Add centerpoint_rpn and scn, change pillar encoder and voxel_encoder.

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #46 into master will increase coverage by 2.90%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   48.47%   51.37%   +2.90%     
==========================================
  Files         139      139              
  Lines        8435     8453      +18     
  Branches     1304     1308       +4     
==========================================
+ Hits         4089     4343     +254     
+ Misses       4087     3831     -256     
- Partials      259      279      +20     
Flag Coverage Δ
#unittests 51.37% <71.42%> (+2.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/middle_encoders/sparse_encoder.py 67.85% <55.55%> (-4.15%) ⬇️
mmdet3d/models/voxel_encoders/pillar_encoder.py 56.89% <55.55%> (-1.29%) ⬇️
mmdet3d/models/necks/second_fpn.py 88.57% <100.00%> (+1.90%) ⬆️
mmdet3d/models/voxel_encoders/voxel_encoder.py 52.43% <100.00%> (+1.34%) ⬆️
mmdet3d/core/bbox/structures/base_box3d.py 75.00% <0.00%> (+0.69%) ⬆️
mmdet3d/core/anchor/anchor_3d_generator.py 93.27% <0.00%> (+6.72%) ⬆️
mmdet3d/core/voxel/voxel_generator.py 33.33% <0.00%> (+20.37%) ⬆️
mmdet3d/core/evaluation/kitti_utils/eval.py 33.00% <0.00%> (+27.63%) ⬆️
mmdet3d/core/bbox/transforms.py 80.95% <0.00%> (+57.14%) ⬆️
...d/core/bbox/coders/partial_bin_based_bbox_coder.py 92.85% <0.00%> (+71.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c63a68...aedad0a. Read the comment docs.

@yinchimaoliang yinchimaoliang force-pushed the add_modules_before_mg_head branch 2 times, most recently from 6b7c66a to 0ae4ca8 Compare August 2, 2020 03:03
tests/test_necks.py Outdated Show resolved Hide resolved
tests/test_necks.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit 27d0001 into open-mmlab:master Aug 18, 2020
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* [Refactor] add enum class and use functions to get configuration (open-mmlab#40)

* add task and codebase enum class

* use funcitons to get config

* Refactor wrappers of mmcls and mmseg (open-mmlab#41)

* move wrappers of cls & det to apis

* remove get_classes_from_config

* rename onnx_helper to onnx_utils

* move import to outside of class

* refactor ortwrappers

* Refactor build dataset and dataloader for mmseg (open-mmlab#44)

* refactor build_dataset and build_dataloader for mmcls and mmseg

* remove repeated classes

* set build_dataloader with shuffle=False

* [Refactor] pplwrapper and mmocr refactor (open-mmlab#46)

* add

* add pplwrapper and refactor mmocr

* fix lint

* remove unused arguments

* apply dict input for pplwrapper and ortwrapper

* add condition before import ppl and ort stuff

* update ppl (open-mmlab#51)

* Refactor return value and extract_model (open-mmlab#54)

* remove ret_value

* refactor extract_model

* fix typo

* resolve comments

* [Refactor] Refactor model inference pipeline (open-mmlab#52)

* move attribute_to_dict to extract_model

* simplify the inference and visualization

* remove unused import

* [Feature] Support SRCNN in mmedit with ONNXRuntime and TensorRT (open-mmlab#45)

* finish mmedit-ort

* edit __init__ files

* add noqa

* add tensorrt support

* 1. Rename "base.py"
2. Move srcnn.py to correct directory

* fix bugs

* remove figures

* align to refactor-v1

* update comment in srcnn

* fix lint

* newfunc -> new_func

* Add visualize.py

split visualize() in each codebase

* fix lint

* fix lint

* remove unnecessary code in ORTRestorer

* remove .api

* edit super(), remove dataset

* [Refactor]: Change name of split to partition (open-mmlab#57)

* refactor mmcls configs

* refactor mmdet configs and split params

* rename rest split to partition from master

* remove base.py

* fix init of inference class

* fix mmocr init, add show_result alias

Co-authored-by: AllentDan <41138331+AllentDan@users.noreply.github.com>
Co-authored-by: RunningLeon <maningsheng@sensetime.com>
Co-authored-by: Yifan Zhou <singlezombie@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants