-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] enable visualization of the demo results online #473
Conversation
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
- Coverage 51.05% 51.04% -0.01%
==========================================
Files 187 187
Lines 13799 13801 +2
Branches 2238 2238
==========================================
Hits 7045 7045
- Misses 6277 6279 +2
Partials 477 477
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@wHao-Wu Are we able to visualize img and points at the same time? As far as I know, we need to press BTW, in multi-modality browse_dataset, I first show 3D point results, and then show 2D img results when the user exits 3D window. |
result_path = osp.join(out_dir, filename) | ||
mmcv.mkdir_or_exist(result_path) | ||
show_path = osp.join(result_path, f'{filename}_online.png') | ||
vis.show(show_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should save the online results every time, at least let's pass a parameter to determine whether to save? Like what I've done here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your advice. I have also considered the problem of mandatory saving online results. I will modify the corresponding operation lately.
I am sorry I have not explained the problem clearly. I mean that maybe we don't need to visualize the points results every time because we have shown the final results in which the detected boxes have been drawn in images. |
Maybe we can ask what @ZwwWayne thinks. In my opinion, both 3d points and 2d image are input data so it would be better if we show both? |
@Wuziyi616 , Is there a way to update the open3d visualization window without pressing |
Risk: Whether to simultaneously visualize the point and image results online when visualizing multi-modality demo?