Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] enable visualization of the demo results online #473

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

wHao-Wu
Copy link
Contributor

@wHao-Wu wHao-Wu commented Apr 22, 2021

  • Enabling visualization of the pcd demo results online
  • Enabling visualization of the multi-modality demo results online

Risk: Whether to simultaneously visualize the point and image results online when visualizing multi-modality demo?

@wHao-Wu
Copy link
Contributor Author

wHao-Wu commented Apr 22, 2021

PCD demo

SECOND:

kitti_000008_online

VoteNet:

sunrgbd_000017_online

Multi-modality demo

MVX:

kitti_000008_online

ImVoteNet:

sunrgbd_000017_online

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #473 (19f20f8) into master (6942cf9) will decrease coverage by 0.00%.
The diff coverage is 63.63%.

❗ Current head 19f20f8 differs from pull request most recent head 5a046af. Consider uploading reports for the commit 5a046af to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
- Coverage   51.05%   51.04%   -0.01%     
==========================================
  Files         187      187              
  Lines       13799    13801       +2     
  Branches     2238     2238              
==========================================
  Hits         7045     7045              
- Misses       6277     6279       +2     
  Partials      477      477              
Flag Coverage Δ
unittests 51.04% <63.63%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/visualizer/show_result.py 64.03% <55.55%> (-1.15%) ⬇️
mmdet3d/apis/inference.py 56.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6942cf9...5a046af. Read the comment docs.

@Wuziyi616
Copy link
Contributor

@wHao-Wu Are we able to visualize img and points at the same time? As far as I know, we need to press q to exit open3d.vis and mmcv.imshow(). How can you show them simultaneously? I know there is a so-called non-blocking mode in opencv but I haven't tried that before.

BTW, in multi-modality browse_dataset, I first show 3D point results, and then show 2D img results when the user exits 3D window.

result_path = osp.join(out_dir, filename)
mmcv.mkdir_or_exist(result_path)
show_path = osp.join(result_path, f'{filename}_online.png')
vis.show(show_path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should save the online results every time, at least let's pass a parameter to determine whether to save? Like what I've done here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your advice. I have also considered the problem of mandatory saving online results. I will modify the corresponding operation lately.

@wHao-Wu wHao-Wu closed this Apr 22, 2021
@wHao-Wu wHao-Wu reopened this Apr 22, 2021
@wHao-Wu
Copy link
Contributor Author

wHao-Wu commented Apr 22, 2021

@wHao-Wu Are we able to visualize img and points at the same time? As far as I know, we need to press q to exit open3d.vis and mmcv.imshow(). How can you show them simultaneously? I know there is a so-called non-blocking mode in opencv but I haven't tried that before.

BTW, in multi-modality browse_dataset, I first show 3D point results, and then show 2D img results when the user exits 3D window.

I am sorry I have not explained the problem clearly. I mean that maybe we don't need to visualize the points results every time because we have shown the final results in which the detected boxes have been drawn in images.

@Wuziyi616
Copy link
Contributor

@wHao-Wu Are we able to visualize img and points at the same time? As far as I know, we need to press q to exit open3d.vis and mmcv.imshow(). How can you show them simultaneously? I know there is a so-called non-blocking mode in opencv but I haven't tried that before.
BTW, in multi-modality browse_dataset, I first show 3D point results, and then show 2D img results when the user exits 3D window.

I am sorry I have not explained the problem clearly. I mean that maybe we don't need to visualize the points results every time because we have shown the final results in which the detected boxes have been drawn in images.

Maybe we can ask what @ZwwWayne thinks. In my opinion, both 3d points and 2d image are input data so it would be better if we show both?

@baheytharwat
Copy link

@wHao-Wu Are we able to visualize img and points at the same time? As far as I know, we need to press q to exit open3d.vis and mmcv.imshow(). How can you show them simultaneously? I know there is a so-called non-blocking mode in opencv but I haven't tried that before.

BTW, in multi-modality browse_dataset, I first show 3D point results, and then show 2D img results when the user exits 3D window.

@Wuziyi616 , Is there a way to update the open3d visualization window without pressing q each time? I am using show_result_meshlab function from the demo example
I just want to display the detection results of multiple point clouds sequentially without pressing any key

tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
)

* upload

* add fake_multiclass_nms_rotated

* delete unused code

* align with pytorch

* Update delta_midpointoffset_rbbox_coder.py

* rewrite atan2

* Update bbox_nms.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants