Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #473 changed default arg value for show_result and caused --show broke during testing #515

Merged
merged 1 commit into from
May 7, 2021

Conversation

haotian-liu
Copy link
Contributor

In #473, it changed the default arg value of mmdet3d.core.visualizer.show_result, from show=True to show=False, which caused code mmdet3d.models.detectors.{mvx_two_stage/base}.show_results to broke (not showing the visualization even when --show is enabled during testing.

@CLAassistant
Copy link

CLAassistant commented May 4, 2021

CLA assistant check
All committers have signed the CLA.

@wHao-Wu wHao-Wu self-requested a review May 6, 2021 01:37
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #515 (66edf10) into master (b255d16) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #515   +/-   ##
=======================================
  Coverage   50.66%   50.66%           
=======================================
  Files         189      189           
  Lines       14455    14455           
  Branches     2366     2366           
=======================================
  Hits         7324     7324           
  Misses       6638     6638           
  Partials      493      493           
Flag Coverage Δ
unittests 50.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/visualizer/show_result.py 64.34% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b255d16...66edf10. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 5f674b4 into open-mmlab:master May 7, 2021
@OpenMMLab-Coodinator
Copy link

Hi @haotian-liu !First of all, we want to express our gratitude for your significant PR in this project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants