Fix: #473 changed default arg value for show_result
and caused --show
broke during testing
#515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #473, it changed the default arg value of
mmdet3d.core.visualizer.show_result
, fromshow=True
toshow=False
, which caused codemmdet3d.models.detectors.{mvx_two_stage/base}.show_results
to broke (not showing the visualization even when--show
is enabled during testing.