Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Supplying the model for lyft trained by pointpillars #578

Merged
merged 3 commits into from
May 26, 2021

Conversation

wHao-Wu
Copy link
Contributor

@wHao-Wu wHao-Wu commented May 24, 2021

  • Supplying the model for lyft trained by pointpillars with FPN architecture
  • Supplying the model for lyft trained by pointpillars with SECFPN architecture

@wHao-Wu wHao-Wu requested a review from ZwwWayne May 24, 2021 01:57
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #578 (df8efc5) into master (b3a6346) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   50.77%   50.77%           
=======================================
  Files         197      197           
  Lines       14923    14923           
  Branches     2426     2426           
=======================================
  Hits         7577     7577           
  Misses       6851     6851           
  Partials      495      495           
Flag Coverage Δ
unittests 50.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3a6346...df8efc5. Read the comment docs.

Copy link
Collaborator

@yezhen17 yezhen17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that the links are valid.

@yezhen17 yezhen17 linked an issue May 24, 2021 that may be closed by this pull request
@Tai-Wang Tai-Wang self-requested a review May 24, 2021 08:35
Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also modify the corresponding benchmarks in other config folders like regnet and ssn.

@wHao-Wu
Copy link
Contributor Author

wHao-Wu commented May 24, 2021

Please also modify the corresponding benchmarks in other config folders like regnet and ssn.

Thanks for your advice. Regnet and ssn model on Lyft is still in progress. I will release those models after completion.

@ZwwWayne ZwwWayne merged commit bc631db into open-mmlab:master May 26, 2021
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* fix ci

* ignore scripts

* remove pycuda from requirements

* fix trt apis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please upload a pointpillars pre-trained model for the lyft dataset
5 participants