Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement][Fix] Copy PR #904 & #915 to the v1 dev branch #963

Closed
wants to merge 2 commits into from
Closed

[Enhancement][Fix] Copy PR #904 & #915 to the v1 dev branch #963

wants to merge 2 commits into from

Conversation

zhanggefan
Copy link
Contributor

Copy PR #904 & #915 to the v1 dev branch

@zhanggefan zhanggefan changed the title [Enhancement] faster but nondeterministic version of hard voxelizatio… [Enhancement][Fix] Copy PR #904 & #915 to the v1 dev branch Sep 24, 2021
@Tai-Wang
Copy link
Member

Hi @zhanggefan , we will rebase v1.0.0.dev0 with the latest master from time to time when several new PRs are merged into master, so I think this PR is not necessary?

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #963 (ba91f51) into v1.0.0.dev0 (4a804bf) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head ba91f51 differs from pull request most recent head 53d7836. Consider uploading reports for the commit 53d7836 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           v1.0.0.dev0     #963      +/-   ##
===============================================
- Coverage        50.50%   50.50%   -0.01%     
===============================================
  Files              226      226              
  Lines            16825    16827       +2     
  Branches          2697     2697              
===============================================
+ Hits              8498     8499       +1     
- Misses            7796     7797       +1     
  Partials           531      531              
Flag Coverage Δ
unittests 50.50% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/ops/voxel/voxelize.py 80.76% <50.00%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a804bf...53d7836. Read the comment docs.

@zhanggefan
Copy link
Contributor Author

@Tai-Wang Ok I got it. Close this for now.

@zhanggefan zhanggefan closed this Sep 24, 2021
@zhanggefan zhanggefan deleted the nondeterministic_hv_dev branch October 4, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants