Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #630: Add input size check to model_inference #633

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

mpena-vina
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2021

CLA assistant check
All committers have signed the CLA.

mmocr/apis/inference.py Outdated Show resolved Hide resolved
tests/test_apis/test_model_inference.py Outdated Show resolved Hide resolved
tests/test_apis/test_model_inference.py Outdated Show resolved Hide resolved
mmocr/apis/inference.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #633 (3ea6282) into main (69d5040) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
- Coverage   84.94%   84.90%   -0.04%     
==========================================
  Files         143      143              
  Lines        9808     9810       +2     
  Branches     1468     1469       +1     
==========================================
- Hits         8331     8329       -2     
- Misses       1149     1151       +2     
- Partials      328      330       +2     
Flag Coverage Δ
unittests 84.90% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmocr/apis/inference.py 70.58% <100.00%> (+0.50%) ⬆️
mmocr/models/textrecog/convertors/seg.py 89.04% <0.00%> (-5.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69d5040...3ea6282. Read the comment docs.

@mpena-vina mpena-vina requested a review from cuhk-hbsun December 1, 2021 12:30
@cuhk-hbsun cuhk-hbsun merged commit d3d5618 into open-mmlab:main Dec 2, 2021
gaotongxiao pushed a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
…ab#633)

* fix open-mmlab#630: Add input size check to model_inference

* fix open-mmlab#630: Added exception when receiving empty image
gaotongxiao pushed a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
…ab#633)

* fix open-mmlab#630: Add input size check to model_inference

* fix open-mmlab#630: Added exception when receiving empty image
@OpenMMLab-Assistant003
Copy link

Hi @mpena-vina!First of all, we want to express our gratitude for your significant PR in the MMOCR project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @mpena-vina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants