Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix Windows style path in Windows pre-commit #1282

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

liqikai9
Copy link
Collaborator

@liqikai9 liqikai9 commented Apr 1, 2022

Motivation

Related PR: open-mmlab/mmsegmentation#1407.

In Windows OS, the pre-commit would generate model-index.yml with Windows path style, which is not compatible with Linux.

Modification

  1. Use .replace('\\', '/') for path.

  2. Explicitly use encoding='utf-8' when reading md files.

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@liqikai9 liqikai9 requested a review from ly015 April 1, 2022 07:49
@ly015 ly015 changed the base branch from master to dev-0.25 April 2, 2022 02:10
@ly015 ly015 changed the base branch from dev-0.25 to master April 2, 2022 02:12
@ly015 ly015 merged commit c713a34 into open-mmlab:master Apr 2, 2022
@liqikai9 liqikai9 deleted the fix_windows_path branch September 18, 2022 07:59
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants