Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix windows-style path in md2yml.py in Windows pre-commit. #1407

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

MengzhangLI
Copy link
Contributor

Motivation

In Windows OS, the pre-commit would generate model-index.yml with Windows path style.

For example:

image

Solution

Using .replace('\\', '/') for path.

@MengzhangLI MengzhangLI self-assigned this Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1407 (cdc295c) into master (98984bf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1407   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files         133      133           
  Lines        7906     7906           
  Branches     1318     1318           
=======================================
  Hits         7147     7147           
  Misses        536      536           
  Partials      223      223           
Flag Coverage Δ
unittests 90.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98984bf...cdc295c. Read the comment docs.

@MeowZheng MeowZheng merged commit 0d51115 into open-mmlab:master Mar 23, 2022
MeowZheng pushed a commit that referenced this pull request Apr 5, 2022
* [Feature] Provide URLs of Swin Transformer pretrained models

* [Feature] Add multi machine `dist_train`. (#1383)

* Add training startup documentation

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* delete pretrained=None in all six config files

* [Fix] make arguments effective in tools/confusion_matrix.py (#1401)

* add an argument for customizing `title' of the output figure

* fix `color_theme' arguments not passing to plot function

Signed-off-by: code14 <mob5566@gmail.com>

* colab notebook: fix outdated link for doc (#1392)

* colab notebook: fix outdated link for doc

Fixed outdated link for how to customize your datasets by reorganizing data.

* fix lint

* fix typo (#1405)

* [Fix] Fix windows-style path in `md2yml.py` in Windows pre-commit.  (#1407)

* test

* avoid windows path

* [Fix] fix the config name style description (#1414)

Co-authored-by: FangjianLin <93248678+linfangjian01@users.noreply.github.com>
Co-authored-by: Cody Wong <mob5566@gmail.com>
Co-authored-by: Nemo Xiong <xiongnemo@126.com>
Co-authored-by: Xiangxu-0103 <xuxiang0103@gmail.com>
Co-authored-by: Rockey <41846794+RockeyCoss@users.noreply.github.com>
mob5566 pushed a commit to mob5566/mmsegmentation that referenced this pull request Apr 13, 2022
mob5566 added a commit to mob5566/mmsegmentation that referenced this pull request Apr 13, 2022
…lab#1389)

* [Feature] Provide URLs of Swin Transformer pretrained models

* [Feature] Add multi machine `dist_train`. (open-mmlab#1383)

* Add training startup documentation

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* delete pretrained=None in all six config files

* [Fix] make arguments effective in tools/confusion_matrix.py (open-mmlab#1401)

* add an argument for customizing `title' of the output figure

* fix `color_theme' arguments not passing to plot function

Signed-off-by: code14 <mob5566@gmail.com>

* colab notebook: fix outdated link for doc (open-mmlab#1392)

* colab notebook: fix outdated link for doc

Fixed outdated link for how to customize your datasets by reorganizing data.

* fix lint

* fix typo (open-mmlab#1405)

* [Fix] Fix windows-style path in `md2yml.py` in Windows pre-commit.  (open-mmlab#1407)

* test

* avoid windows path

* [Fix] fix the config name style description (open-mmlab#1414)

Co-authored-by: FangjianLin <93248678+linfangjian01@users.noreply.github.com>
Co-authored-by: Cody Wong <mob5566@gmail.com>
Co-authored-by: Nemo Xiong <xiongnemo@126.com>
Co-authored-by: Xiangxu-0103 <xuxiang0103@gmail.com>
Co-authored-by: Rockey <41846794+RockeyCoss@users.noreply.github.com>
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
…lab#1389)

* [Feature] Provide URLs of Swin Transformer pretrained models

* [Feature] Add multi machine `dist_train`. (open-mmlab#1383)

* Add training startup documentation

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* delete pretrained=None in all six config files

* [Fix] make arguments effective in tools/confusion_matrix.py (open-mmlab#1401)

* add an argument for customizing `title' of the output figure

* fix `color_theme' arguments not passing to plot function

Signed-off-by: code14 <mob5566@gmail.com>

* colab notebook: fix outdated link for doc (open-mmlab#1392)

* colab notebook: fix outdated link for doc

Fixed outdated link for how to customize your datasets by reorganizing data.

* fix lint

* fix typo (open-mmlab#1405)

* [Fix] Fix windows-style path in `md2yml.py` in Windows pre-commit.  (open-mmlab#1407)

* test

* avoid windows path

* [Fix] fix the config name style description (open-mmlab#1414)

Co-authored-by: FangjianLin <93248678+linfangjian01@users.noreply.github.com>
Co-authored-by: Cody Wong <mob5566@gmail.com>
Co-authored-by: Nemo Xiong <xiongnemo@126.com>
Co-authored-by: Xiangxu-0103 <xuxiang0103@gmail.com>
Co-authored-by: Rockey <41846794+RockeyCoss@users.noreply.github.com>
@MengzhangLI MengzhangLI deleted the temp_win branch July 15, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants