Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] make arguments effective in tools/confusion_matrix.py #1401

Merged
merged 1 commit into from
Mar 21, 2022
Merged

[Fix] make arguments effective in tools/confusion_matrix.py #1401

merged 1 commit into from
Mar 21, 2022

Conversation

mob5566
Copy link
Contributor

@mob5566 mob5566 commented Mar 20, 2022

Motivation

There are some arguments of tools/confusion_matrix.py is not effective, and this pull request aims to fix that.

Modification

Fixing the arguments passing for the plot function.

BC-breaking (Optional)

NA

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@mob5566
[Fix] make arguments effective in tools/confusion_matrix.py
86f6f8d 
* add an argument for customizing `title' of the output figure

* fix `color_theme' arguments not passing to plot function

Signed-off-by: code14 <mob5566@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Mar 20, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

MeowZheng
MeowZheng approved these changes Mar 20, 2022
View reviewed changes
Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution. It looks good to me.

@MeowZheng MeowZheng merged commit 18859e4 into open-mmlab:master Mar 21, 2022
MeowZheng pushed a commit that referenced this pull request Apr 5, 2022
@MengzhangLI @linfangjian01
@mob5566 @xiongnemo @Xiangxu-0103 @RockeyCoss
[Feature] Provide URLs of Swin Transformer pretrained models (#1389)
ecd2dc4 
* [Feature] Provide URLs of Swin Transformer pretrained models

* [Feature] Add multi machine `dist_train`. (#1383)

* Add training startup documentation

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* delete pretrained=None in all six config files

* [Fix] make arguments effective in tools/confusion_matrix.py (#1401)

* add an argument for customizing `title' of the output figure

* fix `color_theme' arguments not passing to plot function

Signed-off-by: code14 <mob5566@gmail.com>

* colab notebook: fix outdated link for doc (#1392)

* colab notebook: fix outdated link for doc

Fixed outdated link for how to customize your datasets by reorganizing data.

* fix lint

* fix typo (#1405)

* [Fix] Fix windows-style path in `md2yml.py` in Windows pre-commit.  (#1407)

* test

* avoid windows path

* [Fix] fix the config name style description (#1414)

Co-authored-by: FangjianLin <93248678+linfangjian01@users.noreply.github.com>
Co-authored-by: Cody Wong <mob5566@gmail.com>
Co-authored-by: Nemo Xiong <xiongnemo@126.com>
Co-authored-by: Xiangxu-0103 <xuxiang0103@gmail.com>
Co-authored-by: Rockey <41846794+RockeyCoss@users.noreply.github.com>
mob5566 added a commit to mob5566/mmsegmentation that referenced this pull request Apr 13, 2022
@MengzhangLI @linfangjian01
@mob5566 @xiongnemo @Xiangxu-0103 @RockeyCoss
[Feature] Provide URLs of Swin Transformer pretrained models (open-mm…
b60891c 
…lab#1389)

* [Feature] Provide URLs of Swin Transformer pretrained models

* [Feature] Add multi machine `dist_train`. (open-mmlab#1383)

* Add training startup documentation

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* delete pretrained=None in all six config files

* [Fix] make arguments effective in tools/confusion_matrix.py (open-mmlab#1401)

* add an argument for customizing `title' of the output figure

* fix `color_theme' arguments not passing to plot function

Signed-off-by: code14 <mob5566@gmail.com>

* colab notebook: fix outdated link for doc (open-mmlab#1392)

* colab notebook: fix outdated link for doc

Fixed outdated link for how to customize your datasets by reorganizing data.

* fix lint

* fix typo (open-mmlab#1405)

* [Fix] Fix windows-style path in `md2yml.py` in Windows pre-commit.  (open-mmlab#1407)

* test

* avoid windows path

* [Fix] fix the config name style description (open-mmlab#1414)

Co-authored-by: FangjianLin <93248678+linfangjian01@users.noreply.github.com>
Co-authored-by: Cody Wong <mob5566@gmail.com>
Co-authored-by: Nemo Xiong <xiongnemo@126.com>
Co-authored-by: Xiangxu-0103 <xuxiang0103@gmail.com>
Co-authored-by: Rockey <41846794+RockeyCoss@users.noreply.github.com>
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
@mob5566
[Fix] make arguments effective in tools/confusion_matrix.py (open-mml…
cfc080c 
…ab#1401)

* add an argument for customizing `title' of the output figure

* fix `color_theme' arguments not passing to plot function

Signed-off-by: code14 <mob5566@gmail.com>
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
@MengzhangLI @linfangjian01
@mob5566 @xiongnemo @Xiangxu-0103 @RockeyCoss
[Feature] Provide URLs of Swin Transformer pretrained models (open-mm…
2a30834 
…lab#1389)

* [Feature] Provide URLs of Swin Transformer pretrained models

* [Feature] Add multi machine `dist_train`. (open-mmlab#1383)

* Add training startup documentation

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* delete pretrained=None in all six config files

* [Fix] make arguments effective in tools/confusion_matrix.py (open-mmlab#1401)

* add an argument for customizing `title' of the output figure

* fix `color_theme' arguments not passing to plot function

Signed-off-by: code14 <mob5566@gmail.com>

* colab notebook: fix outdated link for doc (open-mmlab#1392)

* colab notebook: fix outdated link for doc

Fixed outdated link for how to customize your datasets by reorganizing data.

* fix lint

* fix typo (open-mmlab#1405)

* [Fix] Fix windows-style path in `md2yml.py` in Windows pre-commit.  (open-mmlab#1407)

* test

* avoid windows path

* [Fix] fix the config name style description (open-mmlab#1414)

Co-authored-by: FangjianLin <93248678+linfangjian01@users.noreply.github.com>
Co-authored-by: Cody Wong <mob5566@gmail.com>
Co-authored-by: Nemo Xiong <xiongnemo@126.com>
Co-authored-by: Xiangxu-0103 <xuxiang0103@gmail.com>
Co-authored-by: Rockey <41846794+RockeyCoss@users.noreply.github.com>
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
@patrickvonplaten
Make height and width optional (open-mmlab#1401)
e0e86b7 
* fix

* add test

* fix test

* uP

* up

* fix some tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MengzhangLI MengzhangLI MengzhangLI approved these changes

@MeowZheng MeowZheng MeowZheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mob5566 @CLAassistant @MengzhangLI @MeowZheng