Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add mminstall.txt in setup.py #1425

Merged
merged 5 commits into from
Jun 17, 2022

Conversation

liqikai9
Copy link
Collaborator

Motivation

Refer to open-mmlab/mmsegmentation#1655. Add mim to extras_require in setup.py

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@liqikai9
Copy link
Collaborator Author

liqikai9 commented Jun 13, 2022

@ly015 @jin-s13
Should we add these lines as well?

'all': parse_requirements('requirements.txt'),
'optional': parse_requirements('requirements/optional.txt'),

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1425 (3f57372) into master (4f5ec97) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1425      +/-   ##
==========================================
- Coverage   84.35%   84.32%   -0.03%     
==========================================
  Files         232      232              
  Lines       19279    19284       +5     
  Branches     3468     3470       +2     
==========================================
  Hits        16262    16262              
- Misses       2152     2157       +5     
  Partials      865      865              
Flag Coverage Δ
unittests 84.26% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/apis/train.py 21.05% <0.00%> (-1.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5ec97...3f57372. Read the comment docs.

@ly015
Copy link
Member

ly015 commented Jun 14, 2022

@ly015 @jin-s13 Should we add these lines as well?

'all': parse_requirements('requirements.txt'),
'optional': parse_requirements('requirements/optional.txt'),

Yes, please add them.

@ly015 ly015 merged commit 16027f6 into open-mmlab:master Jun 17, 2022
wusize pushed a commit that referenced this pull request Jun 30, 2022
@liqikai9 liqikai9 deleted the add-mim-to-extra-require branch September 18, 2022 08:01
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 5, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants