Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mim to extras_require in setup.py #1655

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

zhouzaida
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add mim to extras_require in setup.py

Modification

Update setup.py

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1655 (09fe8d5) into master (60655de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1655   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files         142      142           
  Lines        8476     8476           
  Branches     1428     1428           
=======================================
  Hits         7650     7650           
  Misses        586      586           
  Partials      240      240           
Flag Coverage Δ
unittests 90.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60655de...09fe8d5. Read the comment docs.

@MeowZheng MeowZheng merged commit 775d05c into open-mmlab:master Jun 9, 2022
@zhouzaida zhouzaida deleted the add-mim-to-extra-require branch June 9, 2022 08:41
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
* Add mim to extras_require in setup.py

* fix typo
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants