-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the 'Optional' extra require in setup.py #1491
Conversation
Added the missing extra of "optional" as seen in other MM repos as mmaction2 (https://github.com/open-mmlab/mmaction2/blob/master/setup.py#L193) and mmdetection (https://github.com/open-mmlab/mmdetection/blob/master/setup.py#L216) Without it, users who are used to install mmlab packages will automatically add the "optional" extra and will encounter a pip error
@danielbraun89 Thanks a lot for your contribution! We will review the PR ASAP. |
Hi @danielbraun89 , do you have any update on this PR? Could you please sign the CLA? So that we can proceed with the code merging |
Codecov Report
@@ Coverage Diff @@
## master #1491 +/- ##
==========================================
- Coverage 84.47% 84.20% -0.28%
==========================================
Files 236 236
Lines 20036 20039 +3
Branches 3602 3603 +1
==========================================
- Hits 16925 16873 -52
- Misses 2231 2270 +39
- Partials 880 896 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* Added the 'Optional' extra require in setup.py Added the missing extra of "optional" as seen in other MM repos as mmaction2 (https://github.com/open-mmlab/mmaction2/blob/master/setup.py#L193) and mmdetection (https://github.com/open-mmlab/mmdetection/blob/master/setup.py#L216) Without it, users who are used to install mmlab packages will automatically add the "optional" extra and will encounter a pip error * move albumentations from optional.txt to albu.txt * addd pip install albumentations command in the workflow Co-authored-by: liqikai <tiger19971215@sjtu.edu.cn>
danielbraun89,您好!您在MMPose项目中给我们提的PR非常重要,感谢您付出私人时间帮助改进开源项目,相信很多开发者会从你的PR中受益。 Hi @danielbraun89 !First of all, we want to express our gratitude for your significant PR in the MMPose project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
* Added the 'Optional' extra require in setup.py Added the missing extra of "optional" as seen in other MM repos as mmaction2 (https://github.com/open-mmlab/mmaction2/blob/master/setup.py#L193) and mmdetection (https://github.com/open-mmlab/mmdetection/blob/master/setup.py#L216) Without it, users who are used to install mmlab packages will automatically add the "optional" extra and will encounter a pip error * move albumentations from optional.txt to albu.txt * addd pip install albumentations command in the workflow Co-authored-by: liqikai <tiger19971215@sjtu.edu.cn>
* Added the 'Optional' extra require in setup.py Added the missing extra of "optional" as seen in other MM repos as mmaction2 (https://github.com/open-mmlab/mmaction2/blob/master/setup.py#L193) and mmdetection (https://github.com/open-mmlab/mmdetection/blob/master/setup.py#L216) Without it, users who are used to install mmlab packages will automatically add the "optional" extra and will encounter a pip error * move albumentations from optional.txt to albu.txt * addd pip install albumentations command in the workflow Co-authored-by: liqikai <tiger19971215@sjtu.edu.cn>
Motivation
Without it, users who are used to install mmlab packages will automatically add the "optional" extra and will encounter a pip error
Modification
Added the missing extra of "optional" as seen in other MM repos as mmaction2 (https://github.com/open-mmlab/mmaction2/blob/master/setup.py#L193) and mmdetection (https://github.com/open-mmlab/mmdetection/blob/master/setup.py#L216)