Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the 'Optional' extra require in setup.py #1491

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Added the 'Optional' extra require in setup.py #1491

merged 3 commits into from
Aug 2, 2022

Commits on Jul 16, 2022

  1. Added the 'Optional' extra require in setup.py 

    Added the missing extra of "optional" as seen in other MM repos as mmaction2  (https://github.com/open-mmlab/mmaction2/blob/master/setup.py#L193)   and mmdetection  (https://github.com/open-mmlab/mmdetection/blob/master/setup.py#L216)  

Without it, users who are used to install mmlab packages will automatically add the "optional" extra and will encounter a pip error
    @danielbraun89
    danielbraun89 authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    341214d View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. move albumentations from optional.txt to albu.txt

    @liqikai9
    liqikai9 committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    c5927df View commit details
    Browse the repository at this point in the history

  2. addd pip install albumentations command in the workflow

    @liqikai9
    liqikai9 committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    b99333f View commit details
    Browse the repository at this point in the history