Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix keypoint_scores in visualization #1671

Merged
merged 4 commits into from
Sep 23, 2022
Merged

[Fix] Fix keypoint_scores in visualization #1671

merged 4 commits into from
Sep 23, 2022

Conversation

liqikai9
Copy link
Collaborator

Motivation

  1. Support nms-thr in topdown_demo_with_mmdet.py;
  2. Fix use keypoint_scores to filter keypoints to be visualized.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@liqikai9 liqikai9 changed the title [Fix] Fix vis score [Fix] Fix keypoint_scores in visualization Sep 20, 2022
@ly015 ly015 requested a review from Ben-Louis September 23, 2022 06:42
@ly015 ly015 merged commit fc7f090 into open-mmlab:dev-1.x Sep 23, 2022
ly015 pushed a commit that referenced this pull request Oct 14, 2022
@liqikai9 @Ben-Louis @ly015
[Fix] Fix keypoint_scores in visualization (#1671)
66c9aa6 
* refine demo and visualization

* refine topdown face demo

* resolve comments

* fix keypoint and skeleton transparency

Co-authored-by: lupeng <penglu2097@gmail.com>
ly015 pushed a commit that referenced this pull request Oct 14, 2022
@liqikai9 @Ben-Louis @ly015
[Fix] Fix keypoint_scores in visualization (#1671)
62af5ba 
* refine demo and visualization

* refine topdown face demo

* resolve comments

* fix keypoint and skeleton transparency

Co-authored-by: lupeng <penglu2097@gmail.com>
@liqikai9 liqikai9 deleted the fix-vis-score branch October 26, 2022 07:22
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
@liqikai9 @Ben-Louis @ly015
[Fix] Fix keypoint_scores in visualization (open-mmlab#1671)
460f24b 
* refine demo and visualization

* refine topdown face demo

* resolve comments

* fix keypoint and skeleton transparency

Co-authored-by: lupeng <penglu2097@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ben-Louis Ben-Louis Ben-Louis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liqikai9 @Ben-Louis @ly015