Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix keypoint_scores in visualization #1671

Merged
merged 4 commits into from
Sep 23, 2022
Merged

[Fix] Fix keypoint_scores in visualization #1671

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ab9b39
refine demo and visualization
liqikai9 Sep 20, 2022
b09ba4a
refine topdown face demo
Ben-Louis Sep 23, 2022
e4549b1
resolve comments
liqikai9 Sep 23, 2022
7a7d2dd
fix keypoint and skeleton transparency
liqikai9 Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions demo/topdown_demo_with_mmdet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def visualize_img(args, img_path, detector, pose_estimator, visualizer,
(pred_instance.bboxes, pred_instance.scores[:, None]), axis=1)
bboxes = bboxes[np.logical_and(pred_instance.labels == args.det_cat_id,
pred_instance.scores > args.bbox_thr)]
bboxes = bboxes[nms(bboxes, 0.3)][:, :4]
bboxes = bboxes[nms(bboxes, args.nms_thr)][:, :4]

# predict keypoints
register_mmpose_modules()
Expand Down Expand Up @@ -98,13 +98,18 @@ def main():
type=float,
default=0.3,
help='Bounding box score threshold')
parser.add_argument(
'--nms-thr',
type=float,
default=0.3,
help='Person detection score threshold for NMS')
liqikai9 marked this conversation as resolved.
Show resolved Hide resolved
parser.add_argument(
'--kpt-thr', type=float, default=0.3, help='Keypoint score threshold')
parser.add_argument(
'--draw-heatmap',
action='store_true',
default=False,
help='whether to draw output heatmap')
help='Whether to draw output heatmap')
parser.add_argument(
'--radius',
type=int,
Expand Down
9 changes: 7 additions & 2 deletions demo/topdown_face_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def visualize_img(args, img_path, pose_estimator, visualizer, show_interval):
bboxes = process_face_det_results(face_det_results)

bboxes = np.concatenate((bboxes, np.ones((bboxes.shape[0], 1))), axis=1)
bboxes = bboxes[nms(bboxes, 0.3)][:, :4]
bboxes = bboxes[nms(bboxes, args.nms_thr)][:, :4]

# predict keypoints
pose_results = inference_topdown(pose_estimator, img_path, bboxes)
Expand Down Expand Up @@ -97,13 +97,18 @@ def main():
'Default not saving the visualization images.')
parser.add_argument(
'--device', default='cuda:0', help='Device used for inference')
parser.add_argument(
'--nms-thr',
type=float,
default=0.3,
help='Face detection score threshold for NMS')
liqikai9 marked this conversation as resolved.
Show resolved Hide resolved
parser.add_argument(
'--kpt-thr', type=float, default=0.3, help='Keypoint score threshold')
parser.add_argument(
'--draw-heatmap',
action='store_true',
default=False,
help='whether to draw output heatmap')
help='Whether to draw output heatmap')
parser.add_argument(
'--radius',
type=int,
Expand Down
4 changes: 2 additions & 2 deletions mmpose/visualization/local_visualizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,8 @@ def _draw_instances_kpts(self,
keypoints = instances.get('transformed_keypoints',
instances.keypoints)

if 'scores' in instances and self.show_keypoint_weight:
scores = instances.scores
if 'keypoint_scores' in instances:
Ben-Louis marked this conversation as resolved.
Show resolved Hide resolved
scores = instances.keypoint_scores
else:
scores = [np.ones(len(kpts)) for kpts in keypoints]

Expand Down