Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Remove ema and message_hub when publishing models #2036

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

Tau-J
Copy link
Collaborator

@Tau-J Tau-J commented Mar 9, 2023

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (ffbf595) 82.15% compared to head (25f07a4) 82.17%.

❗ Current head 25f07a4 differs from pull request most recent head b7b372b. Consider uploading reports for the commit b7b372b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2036      +/-   ##
===========================================
+ Coverage    82.15%   82.17%   +0.01%     
===========================================
  Files          224      224              
  Lines        13362    13362              
  Branches      2265     2265              
===========================================
+ Hits         10978    10980       +2     
+ Misses        1873     1869       -4     
- Partials       511      513       +2     
Flag Coverage Δ
unittests 82.17% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/transforms/common_transforms.py 85.67% <0.00%> (+0.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ben-Louis
Copy link
Collaborator

Do you think that 'param_schedulers' should be removed as well?

@Tau-J Tau-J closed this Mar 9, 2023
@Tau-J Tau-J reopened this Mar 9, 2023
@Tau-J Tau-J requested a review from ly015 March 10, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants