Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support iSAID aerial dataset. #1115

Merged
merged 32 commits into from
Feb 17, 2022

Conversation

Waterman0524
Copy link
Contributor

@Waterman0524 Waterman0524 commented Dec 8, 2021

Enhance the dataset diversity for MMSegmentation in Remote Sensing.

Update (2022.01.26)

Config names mIoU (validation) mIoU (ms + flip) GPU memory (MB) FPS
pspnet_r18-d8_4x4_896x896_80k_isaid 60.22 61.25 4626 24.81
pspnet_r50-d8_4x4_896x896_80k_isaid 65.36 66.48 16981 8.42
deeplabv3plus_r18-d8_4x4_896x896_80k_isaid 61.35 62.61 6335 26.91
deeplabv3plus_r50-d8_4x4_896x896_80k_isaid 67.06 68.02 21967 8.88
fcn_hr18s_4x4_896x896_80k_isaid 62.3 62.97 5068 13.84
fcn_hr18_4x4_896x896_80k_isaid 65.06 65.60 8501 7.71
fcn_hr48_4x4_896x896_80k_isaid 67.8 68.53 17293 7.34

TODO

  • Get great numerical results
  • Fix unit test coverage rate
  • Upload models & logs.

@MengzhangLI
Copy link
Contributor

Hi, @Waterman0524 . Could you grant authorization on me about your forked MMSegmentation followed here? Thus I could push my modifications on your branch.

image

Right now there is lint error by our CI in Github. I could use my local pre-commit command to swipe them.

Best,

@MengzhangLI MengzhangLI added the WIP Work in process label Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #1115 (9c9b176) into master (0e3d1b8) will increase coverage by 0.02%.
The diff coverage is 94.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
+ Coverage   90.22%   90.24%   +0.02%     
==========================================
  Files         130      131       +1     
  Lines        7560     7599      +39     
  Branches     1258     1264       +6     
==========================================
+ Hits         6821     6858      +37     
  Misses        531      531              
- Partials      208      210       +2     
Flag Coverage Δ
unittests 90.24% <94.87%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/isaid.py 94.11% <94.11%> (ø)
mmseg/core/evaluation/class_names.py 91.07% <100.00%> (+0.68%) ⬆️
mmseg/datasets/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3d1b8...9c9b176. Read the comment docs.

@MengzhangLI MengzhangLI self-assigned this Dec 10, 2021
@Junjun2016
Copy link
Collaborator

Add class name and palette to mmseg/core/evaluation/class_names.py.

@MengzhangLI MengzhangLI changed the title support iSAID aerial dataset [Feature] Support iSAID aerial dataset. Dec 23, 2021
@MengzhangLI MengzhangLI added the Merging PR waited for merging label Feb 7, 2022
mmseg/datasets/iSAID.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test data is too big to add in seg

Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the crop size (896).

Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have the same concern, why crop_size=896 here? For other datasets, it always is 512 @Waterman0524

mmseg/datasets/iSAID.py Outdated Show resolved Hide resolved
mmseg/datasets/iSAID.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revise mmseg/datasets file and config file iSAID.py to isaid.py

@MengzhangLI MengzhangLI removed WIP Work in process Merging PR waited for merging labels Feb 16, 2022
@MeowZheng MeowZheng merged commit 4f4e772 into open-mmlab:master Feb 17, 2022
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* support iSAID aerial dataset

* Update and rename docs/dataset_prepare.md to 博士/dataset_prepare.md

* Update dataset_prepare.md

* fix typo

* fix typo

* fix typo

* remove imgviz

* fix wrong order in annotation name

* upload models&logs

* upload models&logs

* add load_annotations

* fix unittest coverage

* fix unittest coverage

* fix correct crop size in config

* fix iSAID unit test

* fix iSAID unit test

* fix typos

* fix wrong crop size in readme

* use smaller figure as test data

* add smaller dataset in test data

* add blank in docs

* use 0 bytes pseudo data

* add footnote and comments for crop size

* change iSAID to isaid and add default value in it

* change iSAID to isaid in _base_

Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* make accelerate hard dep

* default fast init

* move params to cpu when device map is None

* handle device_map=None

* handle torch < 1.9

* remove device_map="auto"

* style

* add accelerate in torch extra

* remove accelerate from extras["test"]

* raise an error if torch is available but not accelerate

* update installation docs

* Apply suggestions from code review

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>

* improve defautl loading speed even further, allow disabling fats loading

* address review comments

* adapt the tests

* fix test_stable_diffusion_fast_load

* fix test_read_init

* temp fix for dummy checks

* Trigger Build

* Apply suggestions from code review

Co-authored-by: Anton Lozhkov <anton@huggingface.co>

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Co-authored-by: Anton Lozhkov <anton@huggingface.co>
@OpenMMLab-Assistant003
Copy link

Hi @Waterman0524!First of all, we want to express our gratitude for your significant PR in the MMSegmentation project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @Waterman0524

wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants