Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MMCV's EvalHook in MMSegmentation #438

Merged
merged 11 commits into from
May 5, 2021

Conversation

xiexinch
Copy link
Collaborator

Apply EvalHook and DistEvalHook implemented in MMCV open-mmlab/mmcv#739 .

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #438 (b8eeaa5) into master (1483720) will increase coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head b8eeaa5 differs from pull request most recent head d4df555. Consider uploading reports for the commit d4df555 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
+ Coverage   86.51%   86.60%   +0.09%     
==========================================
  Files          97       99       +2     
  Lines        4967     5152     +185     
  Branches      806      833      +27     
==========================================
+ Hits         4297     4462     +165     
- Misses        517      533      +16     
- Partials      153      157       +4     
Flag Coverage Δ
unittests 86.60% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/__init__.py 73.68% <100.00%> (ø)
mmseg/core/evaluation/eval_hooks.py 95.55% <100.00%> (+6.08%) ⬆️
mmseg/datasets/pascal_context.py 76.47% <0.00%> (-3.53%) ⬇️
mmseg/datasets/pipelines/transforms.py 97.12% <0.00%> (-0.87%) ⬇️
mmseg/models/necks/__init__.py 100.00% <0.00%> (ø)
mmseg/models/backbones/__init__.py 100.00% <0.00%> (ø)
mmseg/models/backbones/vit.py 87.97% <0.00%> (ø)
mmseg/models/necks/multilevel_neck.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1483720...d4df555. Read the comment docs.

@xvjiarui
Copy link
Collaborator

unit test failed.

@xvjiarui
Copy link
Collaborator

We may directly inherit from mmcv instead of define all of them.

@xvjiarui xvjiarui merged commit f933603 into open-mmlab:master May 5, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* mmcv eval hook

* mmcv evalhook compatible

* add warnings

* inherit from base class

* fix unitest

* adapt to mmcv 1.3.1

* fixed unittest

* set by_epoch=False

* fixed efficient test

* update docstring

Co-authored-by: Jiarui XU <xvjiarui0826@gmail.com>
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
* add bu aic

* add aic

* add tests

* add hrnet aic

* fix aic sigmas

* update aic config and checkpoints

* update udp config

* update config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants