[Feature] Support ICNet #884

MengzhangLI · 2021-09-17T13:46:59Z

Support ICNet

codecov · 2021-09-17T14:05:31Z

Codecov Report

Merging #884 (8ae6653) into master (85227b4) will increase coverage by 0.10%.
The diff coverage is 98.75%.

@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
+ Coverage   89.67%   89.78%   +0.10%     
==========================================
  Files         114      116       +2     
  Lines        6431     6510      +79     
  Branches     1007     1011       +4     
==========================================
+ Hits         5767     5845      +78     
  Misses        462      462              
- Partials      202      203       +1

Flag	Coverage Δ
unittests	`89.78% <98.75%> (+0.10%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmseg/models/backbones/icnet.py	`97.50% <97.50%> (ø)`
mmseg/models/backbones/__init__.py	`100.00% <100.00%> (ø)`
mmseg/models/necks/__init__.py	`100.00% <100.00%> (ø)`
mmseg/models/necks/ic_neck.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85227b4...8ae6653. Read the comment docs.

MengzhangLI · 2021-09-17T17:55:17Z

Sources:
https://github.com/liminn/ICNet-pytorch
https://github.com/hszhao/ICNet
https://github.com/lxtGH/Fast_Seg

MMSegmentation:

Can find more results here.

configs/icnet/README.md

configs/icnet/icnet_r101-d8_832x832_160k_cityscapes.py

mmseg/models/backbones/icnet.py

mmseg/models/decode_heads/ic_head.py

tests/test_models/test_backbones/test_icnet.py

tests/test_models/test_heads/test_ic_head.py

mmseg/models/backbones/icnet.py

mmseg/models/decode_heads/__init__.py

mmseg/models/necks/ic_neck.py

Junjun2016 · 2021-11-02T10:58:03Z

Please remove file tools/benchmark_new.py

* add icnet backbone * add icnet head * add icnet configs * nclass -> num_classes * Support ICNet * ICNet * ICNet * Add ICNeck * Add ICNeck * Add ICNeck * Add ICNeck * Adding unittest * Uploading models & logs * Uploading models & logs * add comment * smaller test_swin.py * try to delete test_swin.py * delete test_unet.py * delete test_unet.py * temp * smaller test_unet.py Co-authored-by: Junjun2016 <hejunjun@sjtu.edu.cn>

* re-add RL model code * match model forward api * add register_to_config, pass training tests * fix tests, update forward outputs * remove unused code, some comments * add to docs * remove extra embedding code * unify time embedding * remove conv1d output sequential * remove sequential from conv1dblock * style and deleting duplicated code * clean files * remove unused variables * clean variables * add 1d resnet block structure for downsample * rename as unet1d * fix renaming * rename files * add get_block(...) api * unify args for model1d like model2d * minor cleaning * fix docs * improve 1d resnet blocks * fix tests, remove permuts * fix style * add output activation * rename flax blocks file * Add Value Function and corresponding example script to Diffuser implementation (open-mmlab#884) * valuefunction code * start example scripts * missing imports * bug fixes and placeholder example script * add value function scheduler * load value function from hub and get best actions in example * very close to working example * larger batch size for planning * more tests * merge unet1d changes * wandb for debugging, use newer models * success! * turns out we just need more diffusion steps * run on modal * merge and code cleanup * use same api for rl model * fix variance type * wrong normalization function * add tests * style * style and quality * edits based on comments * style and quality * remove unused var * hack unet1d into a value function * add pipeline * fix arg order * add pipeline to core library * community pipeline * fix couple shape bugs * style * Apply suggestions from code review Co-authored-by: Nathan Lambert <nathan@huggingface.co> * update post merge of scripts * add mdiblock / outblock architecture * Pipeline cleanup (open-mmlab#947) * valuefunction code * start example scripts * missing imports * bug fixes and placeholder example script * add value function scheduler * load value function from hub and get best actions in example * very close to working example * larger batch size for planning * more tests * merge unet1d changes * wandb for debugging, use newer models * success! * turns out we just need more diffusion steps * run on modal * merge and code cleanup * use same api for rl model * fix variance type * wrong normalization function * add tests * style * style and quality * edits based on comments * style and quality * remove unused var * hack unet1d into a value function * add pipeline * fix arg order * add pipeline to core library * community pipeline * fix couple shape bugs * style * Apply suggestions from code review * clean up comments * convert older script to using pipeline and add readme * rename scripts * style, update tests * delete unet rl model file * remove imports in src Co-authored-by: Nathan Lambert <nathan@huggingface.co> * Update src/diffusers/models/unet_1d_blocks.py * Update tests/test_models_unet.py * RL Cleanup v2 (open-mmlab#965) * valuefunction code * start example scripts * missing imports * bug fixes and placeholder example script * add value function scheduler * load value function from hub and get best actions in example * very close to working example * larger batch size for planning * more tests * merge unet1d changes * wandb for debugging, use newer models * success! * turns out we just need more diffusion steps * run on modal * merge and code cleanup * use same api for rl model * fix variance type * wrong normalization function * add tests * style * style and quality * edits based on comments * style and quality * remove unused var * hack unet1d into a value function * add pipeline * fix arg order * add pipeline to core library * community pipeline * fix couple shape bugs * style * Apply suggestions from code review * clean up comments * convert older script to using pipeline and add readme * rename scripts * style, update tests * delete unet rl model file * remove imports in src * add specific vf block and update tests * style * Update tests/test_models_unet.py Co-authored-by: Nathan Lambert <nathan@huggingface.co> * fix quality in tests * fix quality style, split test file * fix checks / tests * make timesteps closer to main * unify block API * unify forward api * delete lines in examples * style * examples style * all tests pass * make style * make dance_diff test pass * Refactoring RL PR (open-mmlab#1200) * init file changes * add import utils * finish cleaning files, imports * remove import flags * clean examples * fix imports, tests for merge * update readmes * hotfix for tests * quality * fix some tests * change defaults * more mps test fixes * unet1d defaults * do not default import experimental * defaults for tests * fix tests * fix-copies * fix * changes per Patrik's comments (open-mmlab#1285) * changes per Patrik's comments * update conversion script * fix renaming * skip more mps tests * last test fix * Update examples/rl/README.md Co-authored-by: Ben Glickenhaus <benglickenhaus@gmail.com>

Junjun2016 and others added 9 commits September 8, 2021 20:15

add icnet backbone

869e5ca

add icnet head

62a9246

add icnet configs

070faaf

nclass -> num_classes

a1872fe

merge master

9df6b86

Support ICNet

7decc3c

Fix docstring and Adding README

e53a1fb

ICNet

fbb013f

ICNet

3930b4b

MengzhangLI requested a review from xvjiarui September 17, 2021 17:11

MengzhangLI mentioned this pull request Sep 17, 2021

[Feature] Support ICNet #863

Closed

3 tasks

MengzhangLI added the WIP Work in process label Sep 18, 2021

MengzhangLI requested a review from Junjun2016 September 18, 2021 03:21

Junjun2016 reviewed Sep 18, 2021

View reviewed changes

configs/icnet/README.md Outdated Show resolved Hide resolved